chore: upgrade SCA, run PHP CS Fixer (#385)

Author: keradus

.github/workflows/static-code-analysis.yml

@@ -14,7 +14,7 @@ jobs:
             -   name: Setup PHP
                 uses: shivammathur/setup-php@v2
                 with:
-                    php-version: 8.1
+                    php-version: 8.3
                     coverage: none
 
             -   name: Validate composer.json

.php-cs-fixer.dist.php

@@ -1,32 +1,28 @@
 <?php
 
-$finder = PhpCsFixer\Finder::create()
+use PhpCsFixer\Config;
+use PhpCsFixer\Finder;
+
+$finder = Finder::create()
     ->ignoreDotFiles(false)
     ->ignoreVCSIgnored(true)
     ->exclude('tests/Fixture')
     ->in(__DIR__)
 ;
 
-$config = new PhpCsFixer\Config();
+$config = new Config();
 $config
     ->setRiskyAllowed(true)
     ->setRules([
         '@PhpCsFixer' => true,
         '@PhpCsFixer:risky' => true,
         '@PHP70Migration' => true,
-        'yoda_style' => [
-            'equal' => false,
-            'identical' => false,
-            'less_and_greater' => false,
-        ],
-        'concat_space' => ['spacing' => 'one'],
-        'explicit_indirect_variable' => false,
-        'explicit_string_variable' => false,
-        'method_chaining_indentation' => false,
-        'php_unit_test_annotation' => false,
-        'single_line_comment_style' => false,
-        'ternary_to_elvis_operator' => false,
-        'visibility_required' => ['elements' => ['method', 'property']],
+        'method_chaining_indentation' => false, // does not fit style of codebase
+        'php_unit_test_annotation' => false, // does not fit style of codebase
+        'php_unit_data_provider_return_type' => false, // for low-level PHP support
+        'ternary_to_elvis_operator' => false, // for low-level PHP support
+        'visibility_required' => ['elements' => ['method', 'property']], // for low-level PHP support
+        'nullable_type_declaration_for_default_null_value' => ['use_nullable_type_declaration' => false], // to support low-end PHP versions
     ])
     ->setFinder($finder)
 ;

composer.json

@@ -66,7 +66,7 @@
             "cd dev-tools && composer install --no-interaction"
         ],
         "sca": [
-            "php dev-tools/vendor/bin/php-cs-fixer fix --dry-run -vv",
+            "php dev-tools/vendor/bin/php-cs-fixer check -vv",
             "php dev-tools/vendor/bin/phpmd src text build/config/phpmd.xml"
         ]
     },

dev-tools/composer.json

@@ -1,6 +1,6 @@
 {
     "require": {
-        "php": "^8.1",
+        "php": "^8.3",
         "ext-json": "*",
         "ext-simplexml": "*"
     },
@@ -14,6 +14,10 @@
     },
     "config": {
         "optimize-autoloader": true,
+        "platform": {
+            "php": "8.3"
+        },
+        "prefer-stable": true,
         "sort-packages": true
     }
 }