Merge branch 'master' into fix/9699-middle-click-tab

Author: adityatoshniwal

docs/en_US/release_notes_9_14.rst

@@ -35,7 +35,10 @@ Bug fixes
   | `Issue #9279 <https://github.com/pgadmin-org/pgadmin4/issues/9279>`_ -  Fixed an issue where OAuth2 authentication fails with 'object has no attribute' if OAUTH2_AUTO_CREATE_USER is False.
   | `Issue #9392 <https://github.com/pgadmin-org/pgadmin4/issues/9392>`_ -  Ensure that the Geometry Viewer refreshes when re-running queries or switching geometry columns, preventing stale data from being displayed.
   | `Issue #9457 <https://github.com/pgadmin-org/pgadmin4/issues/9457>`_ -  Fixed Process Watcher garbled text on Windows with non-UTF-8 locales.
+  | `Issue #9570 <https://github.com/pgadmin-org/pgadmin4/issues/9570>`_ -  Fixed an issue where ALT+F5 for executing a query in the Query Tool shows a crosshair cursor icon for rectangular selection.
+  | `Issue #9648 <https://github.com/pgadmin-org/pgadmin4/issues/9648>`_ -  Fixed an issue where the default fillfactor value for B-tree indexes was incorrect.
   | `Issue #9694 <https://github.com/pgadmin-org/pgadmin4/issues/9694>`_ -  Fixed an issue where AI Reports are grayed out after setting an API key by auto-selecting the default provider.
+  | `Issue #9696 <https://github.com/pgadmin-org/pgadmin4/issues/9696>`_ -  Fixed an issue where AI Assistant does not notify that No API Key or Provider is Set.
   | `Issue #9702 <https://github.com/pgadmin-org/pgadmin4/issues/9702>`_ -  Fixed misleading AI activity messages that could be mistaken for actual database operations.
   | `Issue #9719 <https://github.com/pgadmin-org/pgadmin4/issues/9719>`_ -  Fixed an issue where AI Reports fail with OpenAI models that do not support the temperature parameter.
   | `Issue #9721 <https://github.com/pgadmin-org/pgadmin4/issues/9721>`_ -  Fixed an issue where permissions page is not completely accessible on full scroll.
@@ -45,3 +48,4 @@ Bug fixes
   | `Issue #9736 <https://github.com/pgadmin-org/pgadmin4/issues/9736>`_ -  Fix an issue where the AI Assistant was not retaining conversation context between messages, with chat history compaction to manage token budgets.
   | `Issue #9740 <https://github.com/pgadmin-org/pgadmin4/issues/9740>`_ -  Fixed an issue where the AI Assistant input textbox sometimes swallows the first character of input.
   | `Issue #9758 <https://github.com/pgadmin-org/pgadmin4/issues/9758>`_ -  Clarify where the LLM API key files should be.
+  | `Issue #9789 <https://github.com/pgadmin-org/pgadmin4/issues/9789>`_ -  Fixed an issue where the Query tool kept prompting for a password when using a shared server.

web/pgadmin/browser/__init__.py

@@ -494,6 +494,9 @@ def utils():
     except Exception:
         pg_libpq_version = 0
 
+    # Check if LLM features are enabled (system-level AND provider configured)
+    from pgadmin.llm.utils import is_llm_enabled
+
     for submodule in current_blueprint.submodules:
         snippets.extend(submodule.jssnippets)
 
@@ -538,7 +541,7 @@ def utils():
                 "Administrator") else restricted_shared_storage_list,
             enable_server_passexec_cmd=config.ENABLE_SERVER_PASS_EXEC_CMD,
             max_server_tags_allowed=config.MAX_SERVER_TAGS_ALLOWED,
-            llm_enabled=config.LLM_ENABLED,
+            llm_enabled=is_llm_enabled(),
         ), 200)
     response.headers['Content-Type'] = MIMETYPE_APP_JS
     response.headers['Cache-Control'] = NO_CACHE_CONTROL

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/__init__.py

@@ -517,8 +517,7 @@ def _fetch_properties(self, did, tid, idx):
             "/".join([self.template_path, self._PROPERTIES_SQL]),
             did=did, tid=tid, idx=idx,
             datlastsysoid=self._DATABASE_LAST_SYSTEM_OID,
-            show_sys_objects=self.blueprint.show_system_objects
-        )
+            show_sys_objects=self.blueprint.show_system_objects)
 
         status, res = self.conn.execute_dict(SQL)
         if not status:
@@ -724,8 +723,7 @@ def delete(self, gid, sid, did, scid, tid, **kwargs):
                     "/".join([self.template_path, self._PROPERTIES_SQL]),
                     did=did, tid=tid, idx=idx,
                     datlastsysoid=self._DATABASE_LAST_SYSTEM_OID,
-                    show_sys_objects=self.blueprint.show_system_objects
-                )
+                    show_sys_objects=self.blueprint.show_system_objects)
 
                 status, res = self.conn.execute_dict(SQL)
                 if not status:
@@ -879,8 +877,7 @@ def sql(self, gid, sid, did, scid, tid, idx):
             self.conn, schema=self.schema, table=self.table, did=did,
             tid=tid, idx=idx, datlastsysoid=self._DATABASE_LAST_SYSTEM_OID,
             add_not_exists_clause=True,
-            show_sys_objects=self.blueprint.show_system_objects
-        )
+            show_sys_objects=self.blueprint.show_system_objects)
 
         return ajax_response(response=SQL)
 
@@ -1010,8 +1007,7 @@ def statistics(self, gid, sid, did, scid, tid, idx=None):
                     "/".join([self.template_path, self._PROPERTIES_SQL]),
                     did=did, tid=tid, idx=idx,
                     datlastsysoid=self._DATABASE_LAST_SYSTEM_OID,
-                    show_sys_objects=self.blueprint.show_system_objects
-                )
+                    show_sys_objects=self.blueprint.show_system_objects)
                 status, res = self.conn.execute_dict(SQL)
                 if not status:
                     return internal_server_error(errormsg=res)

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/tests/11_plus/alter_reset_fillfactor_cluster.sql

@@ -6,7 +6,6 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx1_$%{}[]()&*^!@""'`\/#"
     ON public.test_table_for_indexes USING btree
     (id DESC NULLS FIRST, name COLLATE pg_catalog."POSIX" text_pattern_ops DESC NULLS FIRST)
     INCLUDE(name, id)
-    WITH (fillfactor=100)
     TABLESPACE pg_default;
 
 COMMENT ON INDEX public."Idx1_$%{}[]()&*^!@""'`\/#"

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/tests/11_plus/create_btree_desc_null_first.sql

@@ -6,5 +6,5 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx_$%{}[]()&*^!@""'`\/#"
     ON public.test_table_for_indexes USING btree
     (id DESC NULLS FIRST, name COLLATE pg_catalog."POSIX" text_pattern_ops DESC NULLS FIRST)
     INCLUDE(name, id)
-    WITH (fillfactor=100)
+    WITH (fillfactor=90)
     TABLESPACE pg_default;

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/tests/13_plus/alter_expr_statistics.sql

@@ -6,7 +6,7 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx3_$%{}[]()&*^!@""'`\/#"
     ON public.test_table_for_indexes USING btree
     (id ASC NULLS LAST, lower(name) COLLATE pg_catalog."POSIX" text_pattern_ops ASC NULLS LAST)
     INCLUDE(name, id)
-    WITH (fillfactor=10, deduplicate_items=True)
+    WITH (fillfactor=10)
     TABLESPACE pg_default
     WHERE id < 100;
 

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/tests/13_plus/alter_name_fillfactor_comment.sql

@@ -6,7 +6,7 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx1_$%{}[]()&*^!@""'`\/#"
     ON public.test_table_for_indexes USING btree
     (id DESC NULLS FIRST, name COLLATE pg_catalog."POSIX" text_pattern_ops DESC NULLS FIRST)
     INCLUDE(name, id)
-    WITH (fillfactor=10, deduplicate_items=True)
+    WITH (fillfactor=10)
     TABLESPACE pg_default;
 
 ALTER TABLE IF EXISTS public.test_table_for_indexes

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/tests/13_plus/alter_reset_fillfactor_cluster.sql

@@ -6,7 +6,6 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx1_$%{}[]()&*^!@""'`\/#"
     ON public.test_table_for_indexes USING btree
     (id DESC NULLS FIRST, name COLLATE pg_catalog."POSIX" text_pattern_ops DESC NULLS FIRST)
     INCLUDE(name, id)
-    WITH (fillfactor=100, deduplicate_items=True)
     TABLESPACE pg_default;
 
 COMMENT ON INDEX public."Idx1_$%{}[]()&*^!@""'`\/#"

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/tests/13_plus/create_btree_desc_null_first.sql

@@ -6,5 +6,4 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx_$%{}[]()&*^!@""'`\/#"
     ON public.test_table_for_indexes USING btree
     (id DESC NULLS FIRST, name COLLATE pg_catalog."POSIX" text_pattern_ops DESC NULLS FIRST)
     INCLUDE(name, id)
-    WITH (fillfactor=100, deduplicate_items=True)
     TABLESPACE pg_default;

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/tests/13_plus/create_btree_expr_asc_null_last.sql

@@ -6,7 +6,7 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx3_$%{}[]()&*^!@""'`\/#"
     ON public.test_table_for_indexes USING btree
     (id ASC NULLS LAST, lower(name) COLLATE pg_catalog."POSIX" text_pattern_ops ASC NULLS LAST)
     INCLUDE(name, id)
-    WITH (fillfactor=10, deduplicate_items=True)
+    WITH (fillfactor=10)
     TABLESPACE pg_default
     WHERE id < 100;