Commit 09dba28
authored
fix: drop stale ax= kwarg from ArmPlot's robot.plot() call (#590)
BaseRobot.plot() no longer accepts an ax= parameter -- only fig= is a
real, documented parameter; ax isn't referenced anywhere in its body or
docstring, and flows straight through into env.add(), whose signature
(PyPlot.add()) has never accepted ax either. Found via bdsim's ARMPLOT
block, which asserts self.ax is not None and then passes ax=self.ax
into robot.plot(), raising TypeError: PyPlot.add() got an unexpected
keyword argument 'ax'.
self.ax isn't used anywhere else in arm.py -- dropping it from this one
call site is sufficient, robot.plot() manages its own axes internally
given fig=.
Found while investigating a bdsim example (RVC3-python's RRMC.py) that
used to work in the book (2022) -- this was the second of two stacked
bugs blocking it end to end, the first being bdsim's own PROD(matrix=)
removal (unrelated, fixed on the notebook side).1 parent 870c840 commit 09dba28
1 file changed
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
416 | 416 | | |
417 | 417 | | |
418 | 418 | | |
419 | | - | |
420 | 419 | | |
421 | 420 | | |
422 | 421 | | |
| |||
0 commit comments