fix(xpc): make MenuBarItemService talk to ad-hoc-signed parent apps

Upstream PR jordanbaird#903 introduced MenuBarItemService.xpc with this line:

    listener = try XPCListener(service: name,
                               requirement: .isFromSameTeam()) { ... }

`.isFromSameTeam()` requires the listener and every peer to be signed
with the same Apple Team Identifier. That works for builds Jordan
produces from his Developer ID Application certificate. It does NOT
work for any ad-hoc-signed build (TeamIdentifier = empty), because
empty-vs-empty is never treated as a match — the listener rejects
every check-in attempt with "Bogus check-in attempt. Ignoring." and
"Dropping check-in message due to code signing requirement".

The visible symptom is the Menu Bar Layout settings pane spinning
forever on "Loading menu bar items…" — XPC never returns, so Ice
never gets the cached item snapshots. This is the same class of bug
reported in upstream issues jordanbaird#744 (46 reactions) and jordanbaird#891 (30 react-
ions), and it bites every community fork that ships without an Apple
Developer Program account — which is roughly every community fork.

This commit reads the running process's actual Team Identifier via
SecCodeCopySigningInformation; if it's nil (ad-hoc / unsigned), we
fall through to the no-requirement activation path. If it's set
(properly Developer-ID-signed build), behaviour is unchanged — the
strict same-team requirement still applies.

For our fire fork:
  - 0.11.13-fire.0..fire.1 (ad-hoc, this branch's defaults) → fixed.
  - 0.11.13-fire.2+ once signed with our Developer ID → unchanged,
    still uses .isFromSameTeam() because we'll have a team ID.

Also bumps MARKETING_VERSION 0.11.13-fire.1 → 0.11.13-fire.2 and
CURRENT_PROJECT_VERSION 1123 → 1124 so Sparkle in installed fire.1
recognizes this as a newer build and offers the update.

Author: pdurlej

Ice.xcodeproj/project.pbxproj

@@ -417,7 +417,7 @@
 				"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development";
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
-				CURRENT_PROJECT_VERSION = 1123;
+				CURRENT_PROJECT_VERSION = 1124;
 				DEAD_CODE_STRIPPING = YES;
 				DEVELOPMENT_ASSET_PATHS = "";
 				ENABLE_APP_SANDBOX = NO;
@@ -433,7 +433,7 @@
 					"$(inherited)",
 					"@executable_path/../Frameworks",
 				);
-				MARKETING_VERSION = "0.11.13-fire.1";
+				MARKETING_VERSION = "0.11.13-fire.2";
 				PRODUCT_BUNDLE_IDENTIFIER = com.jordanbaird.Ice;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SWIFT_EMIT_LOC_STRINGS = YES;
@@ -450,7 +450,7 @@
 				"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development";
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
-				CURRENT_PROJECT_VERSION = 1123;
+				CURRENT_PROJECT_VERSION = 1124;
 				DEAD_CODE_STRIPPING = YES;
 				DEVELOPMENT_ASSET_PATHS = "";
 				ENABLE_APP_SANDBOX = NO;
@@ -466,7 +466,7 @@
 					"$(inherited)",
 					"@executable_path/../Frameworks",
 				);
-				MARKETING_VERSION = "0.11.13-fire.1";
+				MARKETING_VERSION = "0.11.13-fire.2";
 				PRODUCT_BUNDLE_IDENTIFIER = com.jordanbaird.Ice;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SWIFT_EMIT_LOC_STRINGS = YES;

MenuBarItemService/Listener.swift

@@ -4,6 +4,7 @@
 //
 
 import OSLog
+import Security
 import XPC
 
 /// A wrapper around an XPC listener object.
@@ -24,6 +25,38 @@ final class Listener {
         cancel()
     }
 
+    /// Returns the Team Identifier of the currently running process, or
+    /// `nil` if the binary is unsigned, ad-hoc signed, or the team
+    /// identifier cannot be read.
+    ///
+    /// We need this because `.isFromSameTeam()` (used on macOS 26+ to
+    /// constrain XPC peers) silently rejects every connection when the
+    /// service binary has no team identifier — which is the case for any
+    /// ad-hoc-signed build, including community forks that ship without
+    /// an Apple Developer Program account. Without this check the XPC
+    /// service rejects its own parent app with "Bogus check-in attempt",
+    /// and the Menu Bar Layout pane spins forever on
+    /// "Loading menu bar items…".
+    private static func ownTeamIdentifier() -> String? {
+        var staticCode: SecStaticCode?
+        guard
+            SecStaticCodeCreateWithPath(Bundle.main.bundleURL as CFURL, [], &staticCode) == errSecSuccess,
+            let code = staticCode
+        else {
+            return nil
+        }
+        var info: CFDictionary?
+        guard
+            SecCodeCopySigningInformation(code, SecCSFlags(rawValue: 0), &info) == errSecSuccess,
+            let dict = info as? [String: Any],
+            let teamID = dict[kSecCodeInfoTeamIdentifier as String] as? String,
+            !teamID.isEmpty
+        else {
+            return nil
+        }
+        return teamID
+    }
+
     /// Handles a received message.
     private func handleMessage(_ message: XPCReceivedMessage) -> MenuBarItemService.Response? {
         do {
@@ -73,7 +106,13 @@ final class Listener {
         Logger.default.debug("Activating listener")
 
         do {
-            if #available(macOS 26.0, *) {
+            // On macOS 26+ the listener can constrain peers by team
+            // identifier, but only when we actually have a team
+            // identifier to compare against. Ad-hoc-signed builds (every
+            // community fork without an Apple Developer Program account)
+            // have no team identifier and would reject every connection
+            // — including their own parent app — silently.
+            if #available(macOS 26.0, *), Self.ownTeamIdentifier() != nil {
                 try uncheckedActivateWithSameTeamRequirement()
             } else {
                 try uncheckedActivate()