Skip to content

Commit 2277135

Browse files
committed
chore(buttons): fix jumplinks/tabs button usage
1 parent 9854556 commit 2277135

3 files changed

Lines changed: 55 additions & 11259 deletions

File tree

packages/react-core/src/components/JumpLinks/JumpLinks.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -249,11 +249,13 @@ export const JumpLinks: React.FunctionComponent<JumpLinksProps> = ({
249249
onClick={() => setIsExpanded(!isExpanded)}
250250
aria-label={toggleAriaLabel}
251251
aria-expanded={isExpanded}
252+
icon={
253+
<span className={styles.jumpLinksToggleIcon}>
254+
<AngleRightIcon />
255+
</span>
256+
}
252257
>
253-
<span className={styles.jumpLinksToggleIcon}>
254-
<AngleRightIcon />
255-
</span>
256-
{label && <span> {label} </span>}
258+
{label && label}
257259
</Button>
258260
</div>
259261
)}

packages/react-core/src/components/Tabs/Tabs.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -521,10 +521,12 @@ class Tabs extends React.Component<TabsProps, TabsState> {
521521
aria-expanded={isExpandedLocal}
522522
id={`${randomId}-button`}
523523
aria-labelledby={`${randomId}-text ${randomId}-button`}
524+
icon={
525+
<span className={css(styles.tabsToggleIcon)}>
526+
<AngleRightIcon />
527+
</span>
528+
}
524529
>
525-
<span className={css(styles.tabsToggleIcon)}>
526-
<AngleRightIcon arian-hidden="true" />
527-
</span>
528530
{toggleText && <span id={`${randomId}-text`}>{toggleText}</span>}
529531
</Button>
530532
</div>

0 commit comments

Comments
 (0)