Skip to content

Commit 3a91d79

Browse files
authored
chore: polish release automation and installer docs (#108)
1 parent 706d987 commit 3a91d79

15 files changed

Lines changed: 75 additions & 77 deletions

File tree

.github/workflows/build.yaml

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -29,24 +29,3 @@ jobs:
2929
run: go build -v ./...
3030
- name: Test
3131
run: go test -v ./...
32-
33-
windows-installer:
34-
name: Test Windows installer
35-
runs-on: windows-latest
36-
steps:
37-
- name: Checkout the code
38-
uses: actions/checkout@v4
39-
with:
40-
persist-credentials: false
41-
- name: Test install.ps1
42-
shell: pwsh
43-
run: |
44-
$InstallDir = Join-Path $env:RUNNER_TEMP "pb-bin"
45-
$env:INSTALL_DIR = $InstallDir
46-
.\scripts\install.ps1
47-
48-
if (!(Test-Path "$InstallDir\pb.exe")) {
49-
throw "pb.exe was not installed"
50-
}
51-
52-
& "$InstallDir\pb.exe" --help

.github/workflows/release.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,6 @@ jobs:
2424
go-version-file: go.mod
2525
cache: false
2626

27-
- name: Login to Docker Hub
28-
uses: docker/login-action@v3
29-
with:
30-
username: ${{ secrets.DOCKERHUB_USERNAME }}
31-
password: ${{ secrets.DOCKERHUB_TOKEN }}
32-
3327
- name: Run GoReleaser
3428
uses: goreleaser/goreleaser-action@v6
3529
with:

.goreleaser.yml

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -34,26 +34,3 @@ archives:
3434

3535
checksum:
3636
name_template: "pb_{{ .Version }}_checksums.txt"
37-
38-
dockers:
39-
- id: pb
40-
goos: linux
41-
goarch: amd64
42-
ids:
43-
- pb
44-
image_templates:
45-
- "parseable/pb:{{ .Tag }}"
46-
- "parseable/pb:latest"
47-
skip_push: false
48-
dockerfile: Dockerfile
49-
use: docker
50-
build_flag_templates:
51-
- "--pull"
52-
- "--label=org.opencontainers.image.created={{.Date}}"
53-
- "--label=org.opencontainers.image.title=Parseable"
54-
- "--label=maintainer=Parseable Team <hi@parseable.io>"
55-
- "--label=org.opencontainers.image.vendor=Cloudnatively Pvt Ltd"
56-
- "--label=org.opencontainers.image.licenses=AGPL-3.0"
57-
- "--label=org.opencontainers.image.revision={{.FullCommit}}"
58-
- "--label=org.opencontainers.image.version={{.Version}}"
59-
- "--platform=linux/amd64"

Dockerfile

Lines changed: 0 additions & 5 deletions
This file was deleted.

Makefile

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
PWD := $(shell pwd)
22
GOPATH := $(shell go env GOPATH)
3-
# This is just for development purposes. The version is determined at build time using git tags.
3+
# Local builds use the nearest git tag for version metadata; fall back to "dev".
44
VERSION ?= $(shell git describe --tags 2>/dev/null || echo "dev")
5-
TAG ?= "parseablehq/pb:$(VERSION)"
65
LDFLAGS := $(shell go run buildscripts/gen-ldflags.go $(VERSION))
76

87
GOARCH := $(shell go env GOARCH)
@@ -19,17 +18,14 @@ checks:
1918
getdeps:
2019
@mkdir -p ${GOPATH}/bin
2120
@echo "Installing golangci-lint $(GOLANGCI_LINT_VERSION)"
22-
# Will need to make it more error prone in future!
21+
# TODO: Make dependency installation more robust and reproducible.
2322
@curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(GOPATH)/bin $(GOLANGCI_LINT_VERSION)
2423

2524
crosscompile:
2625
@(env bash $(PWD)/buildscripts/cross-compile.sh)
2726

2827
verifiers: getdeps vet lint
2928

30-
docker: build
31-
@docker build -t $(TAG) . -f Dockerfile.dev
32-
3329
vet:
3430
@echo "Running $@"
3531
@go vet $(PWD)/...

README.md

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,13 @@ Downloads the latest release, verifies the SHA-256 checksum, installs to
7373
`%USERPROFILE%\bin`, and adds that folder to your user `PATH`. Open a new
7474
PowerShell window after installation.
7575

76-
<!-- TODO: Add Homebrew installation here after the tap/formula is available. -->
76+
**Homebrew (macOS and Linux):**
77+
78+
```bash
79+
brew install parseablehq/tap/pb
80+
```
81+
82+
> Use the full tap name above. `brew install pb` installs an unrelated Homebrew cask.
7783
7884
**Pre-built binary (Linux/macOS/Windows):**
7985

@@ -165,7 +171,7 @@ Start with a pre-filled query:
165171
```sh
166172
pb sql run "SELECT * FROM backend-shop WHERE order.amount > 999 LIMIT 5" --from=1h -i
167173
```
168-
<!-- ![pb SQL interactive TUI](docs/images/pb-sql-tui.png) -->
174+
![pb SQL interactive TUI](docs/images/pb-sql-tui.png)
169175

170176
**Run SQL without the TUI:**
171177

@@ -185,7 +191,7 @@ Start with a pre-filled query:
185191
pb promql run "process.cpu.time{process.cpu.state!=""}" --dataset astronomy-shop-metrics --from=1h -i
186192
```
187193

188-
<!-- ![pb PromQL interactive TUI](docs/images/pb-promql-tui.png) -->
194+
![pb PromQL interactive TUI](docs/images/pb-promql-tui.png)
189195

190196
**Run PromQL without the TUI:**
191197

cmd/dataset.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ func init() {
465465
}
466466

467467
var RemoveDatasetCmd = &cobra.Command{
468-
Use: "remove|rm dataset-name",
468+
Use: "remove dataset-name",
469469
Aliases: []string{"rm"},
470470
Example: " pb dataset remove backend_logs\n pb dataset remove backend_logs --type logs",
471471
Short: "Delete a dataset",
@@ -552,7 +552,7 @@ func init() {
552552

553553
// ListDatasetCmd is the list command for datasets
554554
var ListDatasetCmd = &cobra.Command{
555-
Use: "list|ls",
555+
Use: "list",
556556
Aliases: []string{"ls"},
557557
Example: " pb dataset list",
558558
Short: "List all datasets",

cmd/profile.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ var AddProfileCmd = &cobra.Command{
154154
}
155155

156156
var RemoveProfileCmd = &cobra.Command{
157-
Use: "remove|rm profile-name",
157+
Use: "remove profile-name",
158158
Aliases: []string{"rm"},
159159
Example: " pb profile remove local_parseable",
160160
Args: cobra.ExactArgs(1),
@@ -328,7 +328,7 @@ var UpdateProfileCmd = &cobra.Command{
328328
}
329329

330330
var ListProfileCmd = &cobra.Command{
331-
Use: "list|ls profiles",
331+
Use: "list profiles",
332332
Aliases: []string{"ls"},
333333
Short: "List all added profiles",
334334
Example: " pb profile list",

cmd/queryList.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import (
3030
)
3131

3232
var SavedQueryList = &cobra.Command{
33-
Use: "list|ls",
33+
Use: "list",
3434
Aliases: []string{"ls"},
3535
Example: "pb sql list [-o | --output]",
3636
Short: "List of saved queries",

cmd/role.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ var AddRoleCmd = &cobra.Command{
143143
}
144144

145145
var RemoveRoleCmd = &cobra.Command{
146-
Use: "remove|rm role-name",
146+
Use: "remove role-name",
147147
Aliases: []string{"rm"},
148148
Example: " pb role remove ingestor",
149149
Short: "Delete a role",
@@ -188,7 +188,7 @@ var RemoveRoleCmd = &cobra.Command{
188188
}
189189

190190
var ListRoleCmd = &cobra.Command{
191-
Use: "list|ls",
191+
Use: "list",
192192
Aliases: []string{"ls"},
193193
Short: "List all roles",
194194
Example: " pb role list",

0 commit comments

Comments
 (0)