refactor: retire DiskWriter::finish

Author: Devdutt Shenoi

src/parseable/staging/writer.rs

@@ -69,9 +69,11 @@ impl DiskWriter {
     pub fn write(&mut self, rb: &RecordBatch) -> Result<(), StagingError> {
         self.inner.write(rb).map_err(StagingError::Arrow)
     }
+}
 
+impl Drop for DiskWriter {
     /// Write the continuation bytes and mark the file as done, rename to `.data.arrows`
-    pub fn finish(&mut self) {
+    fn drop(&mut self) {
         if let Err(err) = self.inner.finish() {
             error!("Couldn't finish arrow file {:?}, error = {err}", self.path);
             return;
@@ -85,12 +87,6 @@ impl DiskWriter {
     }
 }
 
-impl Drop for DiskWriter {
-    fn drop(&mut self) {
-        self.finish();
-    }
-}
-
 /// Structure to keep recordbatches in memory.
 ///
 /// Any new schema is updated in the schema map.