Hotfix instagram api - #6922
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6922 +/- ##
==========================================
- Coverage 93.85% 93.80% -0.05%
==========================================
Files 169 169
Lines 12220 12220
==========================================
- Hits 11469 11463 -6
- Misses 751 757 +6
Continue to review full report at Codecov.
|
|
thanks @timination can you please run |
|
Sure, apologies I completely forgot about the test cases, they're updated now. Edit: standby, looking into this Travis CI error |
|
No, just bug hunting on GitHub to make better use of my time. It was in response to #6728 |
|
So LGTM based on the docs here: https://developers.facebook.com/docs/instagram-basic-display-api/guides/getting-profiles-and-media Did you test the URL on a local implementation ? |
|
@timination your fix seems good, my bad about the instagram docs, it was not clear. Based on https://developers.facebook.com/docs/instagram-basic-display-api/guides/getting-profiles-and-media your fixe is right ! |
|
@timination can you push again your branch ? |
|
@Moumouls Should be back now |
|
oh dear, I hit re-open and travis CI is gonna fail again lol. I'm not sure why, though. I get many F's even from master branch when running |
Moumouls
left a comment
There was a problem hiding this comment.
LGTM thanks @timination for your contribution :)
|
@timination our ci seems to have some instability and cod cov currently seems to not work properly, on another PR i added some new tests case and we got also a coverage decrease warning. |
|
If you want to be sure about tests, the reopen ci action is currently running: https://github.com/parse-community/parse-server/pull/6922/checks?check_run_id=1194629325 |
|
I'll check it out, thanks @Moumouls =) |
#6728
change from old to new instagram API