Skip to content

Commit d7c19fa

Browse files
committed
Merge org-ai-assisted/master into ai
The branch was created from a stale local master, so its PR diff showed master's newer commits -- including a changelog version bump -- as REMOVALS. Merging rather than rebasing, per the no-history-rewrites rule.
2 parents ec04d7c + 69b1041 commit d7c19fa

2 files changed

Lines changed: 151 additions & 0 deletions

File tree

changelog.upstream

Lines changed: 145 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,148 @@
1+
commit 1db38c8c5b9ae267800c430dc899eff4bda8efa8
2+
Merge: 4694bfb 7a022ad
3+
Author: Patrick Schleizer <adrelanos@whonix.org>
4+
Date: Sat Aug 1 04:33:10 2026 -0400
5+
6+
Merge remote-tracking branch 'refs/remotes/org-ai-assisted/master'
7+
8+
commit 7a022ad13a03cd08f840b341c5e122e31d51f3d7
9+
Merge: 4694bfb 02db0fb
10+
Author: assisted-by-ai (Bot Account) (Machine Account) <228987186+assisted-by-ai@users.noreply.github.com>
11+
Date: Fri Jul 31 15:51:53 2026 -0400
12+
13+
Merge pull request #6 from org-ai-assisted/ai
14+
15+
01_smbios-reader: drive serial and boot immediately under SMBIOS injection
16+
17+
commit 02db0fbc17f462fd9727b7c21fb7a7ab7c24a55e
18+
Author: claude (dev142 b93fb2c6-e15f-4d45-8566-f3ded893b70e) <noreply@anthropic.com>
19+
Date: Fri Jul 31 15:07:20 2026 -0400
20+
21+
ci: add file-based CodeQL python lane
22+
23+
Propagate consumer-codeql-python.yml byte-identically from
24+
developer-meta-files/consumer-templates. vm-config-dist ships real
25+
product Python (wlr resize watcher) that had no python CodeQL analysis.
26+
27+
build-mode none; push/PR/workflow_dispatch triggers. No dm-consumer.yml
28+
section required (reusable soft-skips an absent section).
29+
30+
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
31+
32+
commit 24b1b101fce4a288e642ae22a38da19aa2bbccd2
33+
Author: claude (dev130 fb69d4e9-4716-4e71-ba8c-c9a310d51a5f) <noreply@anthropic.com>
34+
Date: Thu Jul 30 20:09:35 2026 -0400
35+
36+
01_smbios-reader: record why terminal_input is left on serial
37+
38+
- serial-console-enable ships GRUB_TERMINAL="serial", so 00_header emits
39+
`terminal_input serial` before this `01_` snippet runs.
40+
- `set timeout=0` is what makes that harmless: no countdown, so stray serial
41+
input has nothing to interrupt. Restoring a menu wait without pinning
42+
terminal_input would reintroduce the hang.
43+
- Comment only; emitted GRUB block unchanged (parity test 17/17).
44+
45+
commit 24fc31e9e0f16239b28280de7ee71118c01aee56
46+
Author: claude (dev130 fb69d4e9-4716-4e71-ba8c-c9a310d51a5f) <noreply@anthropic.com>
47+
Date: Thu Jul 30 19:35:01 2026 -0400
48+
49+
01_smbios-reader: record why 'console' stays next to 'serial'
50+
51+
- serial-console-enable's 30_serial_console.cfg argues against pairing
52+
them; that file sets GRUB_TERMINAL (input AND output, every boot, real
53+
hardware), where duplicated output and a serial-input menu hijack matter.
54+
- This sets OUTPUT only, on the injection-only test path, and never takes
55+
serial input.
56+
- 'console' keeps video output alive if serial init fails; the EFI
57+
mirroring warned about would garble the harness log loudly, not silently.
58+
- Comment only; the emitted GRUB block is unchanged (parity test 17/17).
59+
60+
commit a3adbc3b8eb3daf26556bbe028a4c31c52902e4e
61+
Author: claude (dev130 fb69d4e9-4716-4e71-ba8c-c9a310d51a5f) <noreply@anthropic.com>
62+
Date: Thu Jul 30 19:10:01 2026 -0400
63+
64+
99_smbios-cmdline: put the placeholder last, guard for nounset
65+
66+
grub-mkconfig emits "${GRUB_CMDLINE_LINUX} ${GRUB_CMDLINE_LINUX_DEFAULT}" and the
67+
kernel takes the last occurrence of a parameter. From GRUB_CMDLINE_LINUX the
68+
placeholder was followed by the image's own tail, measured in a real build as:
69+
70+
... ${dm_smbios_extra} boot-role=sysmaint ... loglevel=0 quiet rd.emergency=halt
71+
72+
so an injected parameter the image also sets was silently defeated -- dm-image-test
73+
injects 'loglevel=3' and never got it, on both the disk and the ISO. Injection is
74+
supposed to win.
75+
76+
Appending to GRUB_CMDLINE_LINUX_DEFAULT puts the placeholder after everything
77+
grub-mkconfig emits, including the sysmaint menuentry's own boot-role parameters, so
78+
the tester's session selection wins too. Recovery entries drop
79+
GRUB_CMDLINE_LINUX_DEFAULT and are therefore not injectable, which is correct: the
80+
tester boots default entries.
81+
82+
Also carries the "cope up with set -o nounset" guard its neighbour
83+
serial-console-enable etc/default/grub.d/30_serial_console.cfg documents and this
84+
file lacked, and drops the header's claim that the placeholder reaches EVERY
85+
generated command line.
86+
87+
Covered by dist-ai dm-grub-smbios-tests, canary-checked both ways.
88+
89+
commit ef9606d97171be7a88ae2cfdef0ee5ee2167ecaa
90+
Author: claude (dev130 fb69d4e9-4716-4e71-ba8c-c9a310d51a5f) <noreply@anthropic.com>
91+
Date: Thu Jul 30 17:40:47 2026 -0400
92+
93+
01_smbios-reader: load serial, clear the SMBIOS variables first
94+
95+
Two findings from the ai-review pass.
96+
97+
insmod serial: the snippet loads regexp and smbios but called 'serial' without
98+
loading it. It resolves today because the grub image already carries the module,
99+
which is luck rather than a guarantee.
100+
101+
Clear dm_smbios_oem and dm_smbios_extra before use: 'smbios' and 'regexp' leave
102+
them untouched when they find no match, and GRUB variables survive grub.cfg's
103+
earlier load_env. A value sitting in grubenv would make an ordinary boot take the
104+
tester path -- serial output and timeout=0 -- with no SMBIOS injection present.
105+
That also hardens the pre-existing cmdline consumer, which had the same exposure
106+
before this branch.
107+
108+
A third finding, that 'terminal_output serial console' hangs when no physical
109+
console is attached, is not correct. 'console' is GRUB's built-in firmware
110+
terminal and is always present; the "not available" warning concerns the serial
111+
terminal. The boot-test run that passed is exactly the described case -- a
112+
headless VM, all twelve legs green.
113+
114+
commit daf5232155cc3ce8749294f672868d965ade7947
115+
Author: claude (dev130 fb69d4e9-4716-4e71-ba8c-c9a310d51a5f) <noreply@anthropic.com>
116+
Date: Thu Jul 30 16:48:05 2026 -0400
117+
118+
01_smbios-reader: drive serial and boot immediately under SMBIOS injection
119+
120+
A boot-tester injects the kernel cmdline via SMBIOS and then drives the guest over
121+
the serial root shell. It cannot interact with the GRUB menu, so on a DISK image
122+
GRUB waits at the menu with its output on a console nobody is reading: qemu runs
123+
with '-vga none -display none', nothing reaches ttyS0, and the tester times out
124+
after ten minutes having captured a 0-byte serial log.
125+
126+
That is the current qcow2 BIOS boot-test failure. The image is fine -- BIOS grub is
127+
installed (grub-cloud-amd64 selected, "Installing for i386-pc platform" ran) and the
128+
same image boots under EFI.
129+
130+
When dm_smbios_extra is non-empty, point GRUB at the serial console and set
131+
timeout=0 so the default entry boots straight through. A normal boot is unaffected:
132+
without injection dm_smbios_extra is empty and the block is skipped, so the menu,
133+
its timeout and the video console behave exactly as before.
134+
135+
Cherry-picked from the fork's ai-boot-test-serial-timeout branch (e25a25d), which
136+
never reached upstream. It has no test-side equivalent -- only the image's GRUB
137+
config can put GRUB's own output on the serial line -- unlike the mount-shared
138+
journal noise, which belongs in dm-image-test and is handled there.
139+
140+
commit 4694bfbbcfe61a6155a0fc4119f5086462a6f59f
141+
Author: Patrick Schleizer <adrelanos@whonix.org>
142+
Date: Wed Jul 29 12:21:40 2026 +0000
143+
144+
bumped changelog version
145+
1146
commit 1c140783056eb2f478c0d1a71dd9785fa9abc3c0
2147
Merge: fcc5301 5be2567
3148
Author: Patrick Schleizer <adrelanos@whonix.org>

debian/changelog

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
vm-config-dist (3:17.5-1) unstable; urgency=medium
2+
3+
* New upstream version (local package).
4+
5+
-- Patrick Schleizer <adrelanos@whonix.org> Sat, 01 Aug 2026 08:45:11 +0000
6+
17
vm-config-dist (3:17.4-1) unstable; urgency=medium
28

39
* New upstream version (local package).

0 commit comments

Comments
 (0)