Skip to content

Commit 18ae487

Browse files
authored
Merge pull request #894 from openstudiocoalition/fix_ci_on_forks
Don't set code signing args for external prs
2 parents 0af206d + de88fad commit 18ae487

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

.github/workflows/app_build.yml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -553,15 +553,21 @@ jobs:
553553
fi
554554
555555
if [ "$RUNNER_OS" == "macOS" ]; then
556+
CODESIGNING_ARGS=()
557+
if [ "$IS_FORK_PR" != "true" ]; then
558+
CODESIGNING_ARGS=(
559+
"-DCPACK_CODESIGNING_DEVELOPPER_ID_APPLICATION:STRING=Developer ID Application: The Energy Coalition (UG9S5ZLM34)"
560+
"-DCPACK_CODESIGNING_NOTARY_PROFILE_NAME:STRING=OpenStudioApplication"
561+
"-DCPACK_CODESIGNING_MACOS_IDENTIFIER:STRING=org.openstudiocoalition.OpenStudioApplication"
562+
)
563+
fi
556564
cmake --preset conan-release -DQT_INSTALL_DIR:PATH=${{ env.QT_INSTALL_DIR }} \
557565
-DBUILD_DOCUMENTATION:BOOL=${{ env.BUILD_DOCUMENTATION }} \
558566
-DBUILD_PACKAGE:BOOL=${{ env.BUILD_PACKAGE }} \
559567
-DCPACK_BINARY_TGZ:BOOL=ON \
560568
-DANALYTICS_API_SECRET:STRING=${{ secrets.ANALYTICS_API_SECRET }} \
561569
-DANALYTICS_MEASUREMENT_ID:STRING=${{ secrets.ANALYTICS_MEASUREMENT_ID }} \
562-
-DCPACK_CODESIGNING_DEVELOPPER_ID_APPLICATION:STRING="Developer ID Application: The Energy Coalition (UG9S5ZLM34)" \
563-
-DCPACK_CODESIGNING_NOTARY_PROFILE_NAME:STRING=OpenStudioApplication \
564-
-DCPACK_CODESIGNING_MACOS_IDENTIFIER:STRING=org.openstudiocoalition.OpenStudioApplication
570+
"${CODESIGNING_ARGS[@]}"
565571
else
566572
cmake --preset conan-release -DQT_INSTALL_DIR:PATH=${{ env.QT_INSTALL_DIR }} \
567573
-DBUILD_DOCUMENTATION:BOOL=${{ env.BUILD_DOCUMENTATION }} \

0 commit comments

Comments
 (0)