fix(workbenches): implement get_username for OpenShift <=4.14

Turns out SelfSubjectReview is only available starting OpenShift 4.15.

fixup incorporate User resource
* RedHatQE/openshift-python-wrapper#2387

fixup incorporate SelfSubjectReview resource
* RedHatQE/openshift-python-wrapper#2389

Author: jiridanek

pyproject.toml

@@ -63,7 +63,7 @@ dependencies = [
     "timeout-sampler>=1.0.6",
     "shortuuid>=1.0.13",
     "jira>=3.8.0",
-    "openshift-python-wrapper>=11.0.38",
+    "openshift-python-wrapper>=11.0.50",
     "semver>=3.0.4",
     "pytest-order>=1.3.0",
     "marshmallow==3.26.1,<4", # this version is needed for pytest-jira

tests/workbenches/conftest.py

@@ -83,6 +83,7 @@ def default_notebook(
 
     # Set the correct username
     username = get_username(dyn_client=admin_client)
+    assert username, "Failed to determine username from the cluster"
 
     # Set the image path based on internal image registry status
     minimal_image_path = (

tests/workbenches/utils.py

@@ -1,11 +1,23 @@
-from kubernetes.dynamic import DynamicClient, Resource, ResourceInstance
+from kubernetes.dynamic import DynamicClient
+from ocp_resources.self_subject_review import SelfSubjectReview
+from ocp_resources.user import User
+from simple_logger.logger import get_logger
 
+LOGGER = get_logger(name=__name__)
 
-def get_username(dyn_client: DynamicClient) -> str:
+
+def get_username(dyn_client: DynamicClient) -> str | None:
     """Gets the username for the client (see kubectl -v8 auth whoami)"""
-    self_subject_review_resource: Resource = dyn_client.resources.get(
-        api_version="authentication.k8s.io/v1", kind="SelfSubjectReview"
-    )
-    self_subject_review: ResourceInstance = dyn_client.create(self_subject_review_resource)
-    username: str = self_subject_review.status.userInfo.username
+    username: str | None
+    try:
+        self_subject_review = SelfSubjectReview(client=dyn_client, name="selfSubjectReview").create()
+        assert self_subject_review
+        username = self_subject_review.status.userInfo.username
+    except NotImplementedError:
+        LOGGER.info(
+            "SelfSubjectReview not found. Falling back to user.openshift.io/v1/users/~ for OpenShift versions <=4.14"
+        )
+        user = User(client=dyn_client, name="~").instance
+        username = user.get("metadata", {}).get("name", None)
+
     return username