Skip to content

Commit 8a89a69

Browse files
Kieleklachmatt
andauthored
ASP.NET and OWIN Instrumentations - fix description for http.server.request.duration metric (#1538)
Co-authored-by: Mateusz Łach <mateusza@splunk.com>
1 parent f06191f commit 8a89a69

6 files changed

Lines changed: 9 additions & 4 deletions

File tree

src/OpenTelemetry.Instrumentation.AspNet/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
## Unreleased
44

5+
* Fix description for `http.server.request.duration` metric.
6+
([#1538](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1538))
7+
58
## 1.7.0-beta.1
69

710
Released 2023-Dec-20

src/OpenTelemetry.Instrumentation.AspNet/Implementation/HttpInMetricsListener.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public HttpInMetricsListener(Meter meter, AspNetMetricsInstrumentationOptions op
2121
this.httpServerDuration = meter.CreateHistogram<double>(
2222
"http.server.request.duration",
2323
unit: "s",
24-
description: "Measures the duration of inbound HTTP requests.");
24+
description: "Duration of HTTP server requests.");
2525
TelemetryHttpModule.Options.OnRequestStoppedCallback += this.OnStopActivity;
2626
this.options = options;
2727
}

src/OpenTelemetry.Instrumentation.AspNet/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ Currently, the instrumentation supports the following metric.
126126

127127
| Name | Instrument Type | Unit | Description |
128128
|-------|-----------------|------|-------------|
129-
| `http.server.duration` | Histogram | `ms` | Measures the duration of inbound HTTP requests. |
129+
| `http.server.request.duration` | Histogram | `s` | Duration of HTTP server requests. |
130130

131131
## Advanced trace configuration
132132

src/OpenTelemetry.Instrumentation.Owin/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
([#929](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/929))
99
* Adds HTTP server metrics via `AddOwinInstrumentation` extension method on `MeterProviderBuilder`
1010
([#1335](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1335))
11+
* Fix description for `http.server.request.duration` metric.
12+
([#1538](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1538))
1113

1214
## 1.0.0-rc.3
1315

src/OpenTelemetry.Instrumentation.Owin/Implementation/OwinInstrumentationMetrics.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@ internal static class OwinInstrumentationMetrics
1414

1515
public static Meter Instance => new Meter(MeterName, AssemblyName.Version.ToString());
1616

17-
public static Histogram<double> HttpServerDuration => Instance.CreateHistogram<double>("http.server.request.duration", "s", "Measures the duration of inbound HTTP requests.");
17+
public static Histogram<double> HttpServerDuration => Instance.CreateHistogram<double>("http.server.request.duration", "s", "Duration of HTTP server requests.");
1818
}

src/OpenTelemetry.Instrumentation.Owin/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ Currently, the instrumentation supports the following metric.
7575

7676
| Name | Instrument Type | Unit | Description |
7777
|-------|-----------------|------|-------------|
78-
| `http.server.request.duration` | Histogram | `s` | Measures the duration of inbound HTTP requests. |
78+
| `http.server.request.duration` | Histogram | `s` | Duration of HTTP server requests. |
7979

8080
## Customize OWIN span names
8181

0 commit comments

Comments
 (0)