respect SilenceSkips in fd mode, add test

Author: woodie

reporters/default_reporter.go

@@ -222,10 +222,6 @@ func (r *DefaultReporter) wrapTextBlock(sectionName string, fn func()) {
 }
 
 func (r *DefaultReporter) DidRun(report types.SpecReport) {
-	if r.conf.FdOutput {
-		r.didRunFd(report)
-		return
-	}
 	v := r.conf.Verbosity()
 	inParallel := report.RunningInParallel
 
@@ -234,6 +230,10 @@ func (r *DefaultReporter) DidRun(report types.SpecReport) {
 		return
 	}
 
+	if r.conf.FdOutput {
+		r.didRunFd(report)
+		return
+	}
 	header := r.specDenoter
 	if report.LeafNodeType.Is(types.NodeTypesForSuiteLevelNodes) {
 		header = fmt.Sprintf("[%s]", report.LeafNodeType)

reporters/default_reporter_test.go

@@ -2961,6 +2961,26 @@ var _ = Describe("DefaultReporter", func() {
 			reporter = reporters.NewDefaultReporterUnderTest(types.ReporterConfig{FdOutput: true}, &buf)
 		})
 
+		Context("with silence-skips enabled", func() {
+			BeforeEach(func() {
+				buf.Reset()
+				reporter = reporters.NewDefaultReporterUnderTest(
+					types.ReporterConfig{FdOutput: true, SilenceSkips: true}, &buf)
+				reporter.SuiteWillBegin(types.Report{})
+				reporter.DidRun(types.SpecReport{
+					ContainerHierarchyTexts: []string{"DescribeA"},
+					LeafNodeText:            "does something",
+					LeafNodeType:            types.NodeTypeIt,
+					State:                   types.SpecStateSkipped,
+				})
+				reporter.SuiteDidEnd(types.Report{SpecReports: types.SpecReports{}})
+			})
+
+			It("omits skipped specs", func() {
+				Expect(buf.String()).NotTo(ContainSubstring("does something"))
+			})
+		})
+
 		Context("with a passing report", func() {
 			BeforeEach(func() {
 				reporter.SuiteWillBegin(types.Report{SuiteDescription: "Something"})