* Apple Notes: keep line breaks and pipes inside a table cell The replace that turned a cell's newlines into <br> threw its result away, so the newline stayed and ended the row - the rest of the cell landed outside the table. It also only ever replaced the first match. Closes obsidianmd#243 * Apple Notes: pass soft returns through as line breaks Shift-Return writes U+2028 rather than ending the paragraph. It went into the markdown as the literal character, which renders as nothing, so a bullet broken that way ran together. It becomes a <br>, or a real newline inside a code block. The recorded internal link moves from Note 14 to Note 15: the fixture note added here shifts the primary keys the attachment rows are given. Closes obsidianmd#328 * Apple Notes: name a note after its own first line ZTITLE1 is an abbreviation Apple stores, cut short with an ellipsis past about eighty characters, and that ellipsis went into the file name. The line itself is in the note text. Of 3812 notes in a real database, 167 were named after a cut-short title; 166 recover, and the one left genuinely ends in an ellipsis. Titles are capped at 200 characters, which a file name has to be and a first line does not. A first line that is only a URL cannot survive as a file name, so it is no longer dropped from the body - a note that was nothing but a link imported empty. Closes obsidianmd#541 Closes obsidianmd#591 * Apple Notes: omit the whole title line, not just the first one Apple takes the title from the first line with anything on it, so a note starting with blank lines has its title further down. Omitting "the first line" stopped at the first blank one and left the title in the body - written twice, once as the file name and once at the top. 143 of 3812 notes in a real database were affected. A title that is the first item of a list is the parent of what follows it, so that one stays: dropping it left its children orphaned and the list gained an empty item in its place. A first item the rest are siblings of still goes. * Apple Notes: write a soft return as a newline rather than a <br> Obsidian renders a newline inside a paragraph as the line break Shift-Return meant, so the markdown does not need the HTML. Inside a list item the line is indented with a tab as well, or it reads as the end of the item. A soft return with nothing before it on its line has no item to continue and stays a bare newline: indenting there leaves a line standing alone after a blank one, which markdown reads as a code block. * Apple Notes: spell out a soft return when the vault needs it A newline renders as a line break unless the vault has strict line breaks turned on, where it does not. The setting is the user's own, so it is read from the vault rather than asked for again, and the break is written as two trailing spaces only where that is what it takes. The vault shim grows getConfig, and settings.test.ts drives the importer for it: the conversion tests build a context of their own and so cannot tell whether the importer fills it in from the right place. * Apple Notes: one bad attachment costs the attachment, not the note resolveAttachment read a column off whatever its lookup returned without checking it returned anything, so an attachment whose row is gone - one iCloud has not brought down - threw. A note's file is created empty before its body is converted, so the throw left the note in the vault with nothing in it: the same bug reported twice, as the error (obsidianmd#218) and as the empty note it leaves behind (obsidianmd#391). A scan reads the cropped copy of a page first and the raw image after it. The first attempt reported a failure even when the second one worked, which is the wall of Failed: "Previews/..." lines in obsidianmd#393; a caller with a fallback left no longer reports one. Closes obsidianmd#218 Closes obsidianmd#391 * Apple Notes: stop reporting a fallback's first attempt, and say where it looked A scan's cropped copy is often not on disk, so the raw image behind it is read instead. That attempt still logged a stack trace for every page of every scan, which reads as a broken import when nothing was lost. An attachment is read from under its account, and from the container for the older ones written before Notes kept accounts apart. Only the second was named when both failed, so the error pointed at a path the importer had not really expected it at. * Apple Notes: a drawing that was never downloaded is skipped, not failed A note can refer to a drawing that only exists in iCloud: no rendered copy, no drawing data, and a size Notes never learned. There is nothing on this Mac to import, and no path worth printing, so reporting it as a failure sends the user looking for a file that was never there. It is reported as skipped instead, with the reason. Opening the note in Apple Notes is what fetches one. * Apple Notes: say which note an attachment came out of, and read as a sentence The log reads Skipped: "<name>" because <reason>, so a reason has to carry on from the because - "not downloaded from iCloud" did not. Nor did the name say which of the drawings in an import it was, since every one of them is called Drawing and the path it was read from is a uuid. Both now name the note holding the attachment, which is the part the user can go and open: Skipped: "Drawing in 2020-04-20" because it has not been downloaded from iCloud - open the note in Apple Notes to fetch it * Apple Notes: trim the comments added along the way Kept the ones carrying something the code cannot say - why a getter, why two paths, what the log's wording has to fit - and dropped the rest. * Apple Notes: report a skipped note under the name it is given The two duplicate-handling messages still named it after ZTITLE1, which is the abbreviation the import no longer uses. Taken from obsidianmd#564. The password-protected one keeps it: the note is not decoded by then, so the stored title is all there is. * Apple Notes: an inline attachment leading a line takes its prefix A link, a mention and a hashtag are attachments, and an attachment was written without the prefix its line calls for. An item starting with one lost its checkbox, and a bulleted line starting with one lost its bullet. A block attachment stands on its own and still takes none. Reported as part of obsidianmd#471. * Apple Notes: escape a hash the text did not mean as a tag Apple marks a real tag as an attachment, so a hash left in the text is not one - a Slack channel, a hashtag in some copy, "#s" for numbers. Obsidian read all of them as tags. 13 notes of 3812 here. Narrow on purpose: "C#" keeps its hash because a tag has to start a word, and "## Heading" keeps both because that is not a tag either. Reported as part of obsidianmd#471. * Apple Notes: record what a tag with a space or only digits does Neither survives as the tag it was: Obsidian reads "#gift ideas" as #gift with stray text after it, and #2024 as no tag at all. What to put in their place is a decision rather than a fix, so this records the behaviour and leaves it (obsidianmd#471.4, obsidianmd#471.6). * Apple Notes: name a media file after what it holds when it has no extension The Evernote web clipper leaves an attachment named as a bare uuid. Obsidian goes by the extension, so the copy landed as a file it would not open and a link that did not resolve. The file is asked what it is instead, and keeps the bare name when its bytes say nothing known. The fixture builder grew media rows for this: the branch that reads an ordinary file attachment had no coverage at all. Reported as part of obsidianmd#471. * Rewrite and remove comments * Apple Notes: fix what the review found in the title and attachment paths An attachment stands in the note text as one character, so a note opening with a photo was named after that character and every such note collided at one name - 21 of 3812 here. A soft return in the first line reached the file name as an invisible separator; it is a space now. Both are read in firstLine, which the title and the URL check share. A soft return inside a code block took the two trailing spaces a hard break is spelled with, putting them in the user's code. A media row with no file name threw where a missing row no longer does, which cost the whole note. The drawing lookup no longer reads the whole drawing blob to ask whether there is one. An extension read from the bytes is part of the name the duplicate check looks for, so it is settled before the check rather than after - a bare-uuid attachment was copied again on every import. The vault shim now keeps the dates it is given, which is what duplicate handling compares. * Apple Notes: keep recognising notes and attachments a previous import wrote A vault an older importer wrote holds a note under the abbreviated ZTITLE1 it used. Recognising one is by path, so naming it from the first line looked where the old file is not and imported it again - under Skip and Import updated alike. Both paths are looked at now. Reading the source to settle an extension put that read in front of the duplicate check, so an attachment Apple has since taken back lost the copy the vault already held. Only a name with no extension needs the bytes; one that already says what it is is checked first. An AVIF names itself in the same place a video does, and was being called mp4, which Obsidian will not embed.

Uh oh!

Apple notes: Title on long notes gets truncated #541

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions