Skip to content

Commit 1c48d0c

Browse files
TheAlexLichterWilcoSpghostdevv
authored
fix: remove ambiguous community wording from replacement suggestions (#2875)
Co-authored-by: Wilco <17604138+WilcoSp@users.noreply.github.com> Co-authored-by: Willow (GHOST) <git@willow.sh>
1 parent 5bb23b4 commit 1c48d0c

35 files changed

Lines changed: 13 additions & 143 deletions

app/components/Compare/ReplacementSuggestion.vue

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -72,29 +72,11 @@ const replacementDescription = useMarkdown(() => ({
7272
<template v-else-if="replacement.type === 'simple'">
7373
<i18n-t keypath="package.replacement.simple">
7474
<template #replacement><span v-html="replacementDescription" /></template>
75-
<template #community>{{ $t('package.replacement.community') }}</template>
7675
</i18n-t>
7776
</template>
78-
<i18n-t
79-
v-else-if="replacement.type === 'documented'"
80-
keypath="package.replacement.documented"
81-
scope="global"
82-
>
83-
<template #replacement>
84-
<code>{{ replacement.replacementModule }}</code>
85-
</template>
86-
<template #community>
87-
<a
88-
href="https://e18e.dev/docs/replacements/"
89-
target="_blank"
90-
rel="noopener noreferrer"
91-
class="inline-flex items-center gap-1 ms-1 underline underline-offset-4 decoration-amber-600/60 dark:decoration-amber-400/50 hover:decoration-fg transition-colors"
92-
>
93-
{{ $t('package.replacement.community') }}
94-
<span class="i-lucide:external-link w-3 h-3" aria-hidden="true" />
95-
</a>
96-
</template>
97-
</i18n-t>
77+
<template v-else-if="replacement.type === 'documented'">
78+
{{ $t('package.replacement.documented') }}
79+
</template>
9880
<template v-else-if="replacement.type === 'removal'">
9981
<span v-html="replacementDescription" />
10082
</template>

app/components/Package/Replacement.vue

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -54,26 +54,9 @@ const replacementDescription = useMarkdown(() => ({
5454
>
5555
</template>
5656
</i18n-t>
57-
<i18n-t
58-
v-else-if="replacement.type === 'documented'"
59-
keypath="package.replacement.documented"
60-
scope="global"
61-
>
62-
<template #replacement>
63-
<code>{{ replacement.replacementModule }}</code>
64-
</template>
65-
<template #community>
66-
<a
67-
href="https://e18e.dev/docs/replacements/"
68-
target="_blank"
69-
rel="noopener noreferrer"
70-
class="inline-flex items-center gap-1 ms-1 underline underline-offset-4 decoration-amber-600/60 dark:decoration-amber-400/50 hover:decoration-fg transition-colors"
71-
>
72-
{{ $t('package.replacement.community') }}
73-
<span class="i-lucide:external-link w-3 h-3" aria-hidden="true" />
74-
</a>
75-
</template>
76-
</i18n-t>
57+
<template v-else-if="replacement.type === 'documented'">
58+
{{ $t('package.replacement.documented') }}
59+
</template>
7760
<template v-else-if="replacement.type === 'removal'">
7861
<span v-html="replacementDescription" />
7962
</template>

i18n/locales/ar.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,12 +173,9 @@
173173
"replacement": {
174174
"title": "قد لا تحتاج إلى هذه التبعية.",
175175
"native": "يمكن استبدالها بـ {replacement}، المتوفرة منذ Node {nodeVersion}.",
176-
"simple": "أشار {community} إلى أن هذه الحزمة زائدة، مع النصيحة: {replacement}.",
177-
"documented": "أشار {community} إلى أن هذه الحزمة لها بدائل أكثر أداءً.",
178176
"none": "تم وضع علامة على هذه الحزمة بأنها لم تعد مطلوبة، ومن المرجح أن وظيفتها متاحة أصلًا في جميع المحركات.",
179177
"learn_more": "اعرف المزيد",
180178
"learn_more_above": "اعرف المزيد أعلاه.",
181-
"community": "المجتمع",
182179
"consider_no_dep": "+ هل تريد خيار «بدون تبعية»؟"
183180
},
184181
"stats": {

i18n/locales/az-AZ.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -256,12 +256,9 @@
256256
"replacement": {
257257
"title": "Bu asılılığa ehtiyacınız olmaya bilər.",
258258
"native": "Bu, Node {nodeVersion}-dən bəri mövcud olan {replacement} ilə əvəz edilə bilər.",
259-
"simple": "{community} bu paketi artıq lazımsız olaraq qeyd edib, tövsiyəsi: {replacement}.",
260-
"documented": "{community} bu paketin daha performanslı alternativlərinin olduğunu qeyd edib.",
261259
"none": "Bu paket artıq lazımsız olaraq qeyd edilib və funksionallığı bütün mühərriklərdə yerli olaraq mövcuddur.",
262260
"learn_more": "Ətraflı öyrən",
263261
"learn_more_above": "Yuxarıda ətraflı öyrənin.",
264-
"community": "icma",
265262
"consider_no_dep": "+ Asılılıqsız düşünün?"
266263
},
267264
"stats": {

i18n/locales/bg-BG.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -219,12 +219,9 @@
219219
"replacement": {
220220
"title": "Може да не се нуждаете от тази зависимост.",
221221
"native": "Това може да бъде заменено с {replacement}, налично от Node {nodeVersion}.",
222-
"simple": "{community} е отбелязала този пакет като излишен, със съвета: {replacement}.",
223-
"documented": "{community} е отбелязала този пакет като имащ по-производителни алтернативи.",
224222
"none": "Този пакет е отбелязан като вече ненужен и функционалността му вероятно е налична нативно във всички двигатели.",
225223
"learn_more": "Научете повече",
226224
"learn_more_above": "Научете повече по-горе.",
227-
"community": "общност",
228225
"consider_no_dep": "+ Обмислете без зависимости?"
229226
},
230227
"stats": {

i18n/locales/bn-IN.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -400,12 +400,9 @@
400400
"example": "উদাহরণ:",
401401
"native": "এটিকে {replacement} দিয়ে প্রতিস্থাপন করা যেতে পারে, যা Node {nodeVersion} থেকে উপলব্ধ।",
402402
"native_no_version": "এই প্যাকেজটি {replacement} দিয়ে প্রতিস্থাপন করা যেতে পারে।",
403-
"simple": "{community} এই প্যাকেজটিকে অনাবশ্যক হিসাবে চিহ্নিত করেছে, পরামর্শ: {replacement}।",
404-
"documented": "{community} এই প্যাকেজটিকে আরো ভাল পারফরম্যান্স অপশন হিসাবে চিহ্নিত করেছে।",
405403
"none": "এই প্যাকেজটি এখন অনাবশ্যক হিসাবে চিহ্নিত, এবং এর কার্যকরিতা সমস্ত ইঞ্জিনে নেটিভভাবে উপলব্ধ হওয়ার সম্ভাবনা আছে।",
406404
"learn_more": "আরো জানুন",
407405
"learn_more_above": "আরো জানুন উপরে।",
408-
"community": "কমিউনিটি",
409406
"consider_no_dep": "+ কোন নির্ভরতা বিবেচনা?"
410407
},
411408
"stats": {

i18n/locales/cs-CZ.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -384,12 +384,9 @@
384384
"replacement": {
385385
"title": "Možná tuto závislost nepotřebujete.",
386386
"native": "Tento balíček lze nahradit {replacement}, dostupné od Node {nodeVersion}.",
387-
"simple": "{community} označila tento balíček jako zbytečný s doporučením: {replacement}.",
388-
"documented": "{community} označila tento balíček jako mající výkonnější alternativy.",
389387
"none": "Tento balíček byl označen jako již nepotřebný a jeho funkčnost je pravděpodobně dostupná nativně ve všech enginech.",
390388
"learn_more": "Zjistit více",
391389
"learn_more_above": "Zjistit více výše.",
392-
"community": "komunita",
393390
"consider_no_dep": "+ Zvážit žádnou závislost?"
394391
},
395392
"stats": {

i18n/locales/de.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -400,12 +400,9 @@
400400
"example": "Beispiel:",
401401
"native": "Dies kann seit Node {nodeVersion} durch {replacement} ersetzt werden.",
402402
"native_no_version": "Dieses Paket kann durch {replacement} ersetzt werden.",
403-
"simple": "Die {community} hat dieses Paket als überflüssig markiert und empfiehlt: {replacement}.",
404-
"documented": "Die {community} hat leistungsstärkere Alternativen für dieses Paket aufgezeigt.",
405403
"none": "Dieses Paket wurde als nicht mehr nötig markiert, und seine Funktionalität ist wahrscheinlich in allen Engines nativ verfügbar.",
406404
"learn_more": "Mehr erfahren",
407405
"learn_more_above": "Erfahre oben mehr.",
408-
"community": "Community",
409406
"consider_no_dep": "+ Ohne Abhängigkeit lösen?"
410407
},
411408
"stats": {

i18n/locales/en.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -427,12 +427,11 @@
427427
"example": "Example:",
428428
"native": "This package can be replaced with {replacement}, available since Node {nodeVersion}.",
429429
"native_no_version": "This package can be replaced with {replacement}.",
430-
"simple": "The {community} has flagged this package as redundant, with the advice: {replacement}",
431-
"documented": "The {community} has flagged this package as having more performant alternatives.",
430+
"simple": "This package has been flagged as redundant, with the advice: {replacement}",
431+
"documented": "This package has been flagged as having more performant alternatives.",
432432
"none": "This package has been flagged as no longer needed, and its functionality is likely available natively in all engines.",
433433
"learn_more": "Learn more",
434434
"learn_more_above": "Learn more above.",
435-
"community": "community",
436435
"consider_no_dep": "+ Consider no dep?"
437436
},
438437
"stats": {

i18n/locales/es.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -400,12 +400,9 @@
400400
"example": "Ejemplo:",
401401
"native": "Esto se puede reemplazar con {replacement}, disponible desde Node {nodeVersion}.",
402402
"native_no_version": "Este paquete se puede reemplazar con {replacement}.",
403-
"simple": "La {community} ha marcado este paquete como redundante, con el siguiente consejo: {replacement}.",
404-
"documented": "La {community} ha señalado que este paquete tiene alternativas con mejor rendimiento.",
405403
"none": "Este paquete se ha marcado como ya no necesario y es probable que su funcionalidad esté disponible de forma nativa en todos los motores.",
406404
"learn_more": "Más información",
407405
"learn_more_above": "Más información arriba.",
408-
"community": "comunidad",
409406
"consider_no_dep": "+ ¿Considerar sin dependencia?"
410407
},
411408
"stats": {

0 commit comments

Comments
 (0)