refactor: centralize error message logging

Author: Christian Medina

lib/install.js

@@ -119,6 +119,7 @@ var unlock = locker.unlock
 var parseJSON = require('./utils/parse-json.js')
 var output = require('./utils/output.js')
 var saveMetrics = require('./utils/metrics.js').save
+var logErrorMessage = require('./utils/log-error-message.js')
 
 // install specific libraries
 var copyTree = require('./install/copy-tree.js')
@@ -342,13 +343,7 @@ Installer.prototype.run = function (_cb) {
     if (installEr) self.failing = true
     chain(postInstallSteps, function (postInstallEr) {
       if (installEr && postInstallEr) {
-        var msg = errorMessage(postInstallEr)
-        msg.summary.forEach(function (logline) {
-          log.warn.apply(log, logline)
-        })
-        msg.detail.forEach(function (logline) {
-          log.verbose.apply(log, logline)
-        })
+        logErrorMessage(postInstallEr, 'warn', 'verbose')
       }
       cb(installEr || postInstallEr, self.getInstalledModules(), self.idealTree)
     })
@@ -736,13 +731,7 @@ Installer.prototype.printWarnings = function (cb) {
     if (warning.code === 'EPACKAGEJSON' && self.global) return
     if (warning.code === 'ENOTDIR') return
     warned = true
-    var msg = errorMessage(warning)
-    msg.summary.forEach(function (logline) {
-      log.warn.apply(log, logline)
-    })
-    msg.detail.forEach(function (logline) {
-      log.verbose.apply(log, logline)
-    })
+    logErrorMessage(warning, 'warn', 'verbose')
   })
   if (warned && log.levels[npm.config.get('loglevel')] <= log.levels.warn) console.error()
   cb()

lib/utils/error-handler.js

@@ -12,7 +12,7 @@ var exitCode = 0
 var rollbacks = npm.rollbacks
 var chain = require('slide').chain
 var writeFileAtomic = require('write-file-atomic')
-var errorMessage = require('./error-message.js')
+var logErrorMessage = require('./log-error-message.js')
 var stopMetrics = require('./metrics.js').stop
 var mkdirp = require('mkdirp')
 var fs = require('graceful-fs')
@@ -198,10 +198,7 @@ function errorHandler (er) {
     if (v) log.error(k, v)
   })
 
-  var msg = errorMessage(er)
-  msg.summary.concat(msg.detail).forEach(function (errline) {
-    log.error.apply(log, errline)
-  })
+  var msg = logErrorMessage(er, 'error', 'error')
   if (npm.config && npm.config.get('json')) {
     var error = {
       error: {

lib/utils/log-error-message.js

@@ -0,0 +1,16 @@
+'use strict'
+var log = require('npmlog')
+var errorMessage = require('./error-message.js')
+
+module.exports = logErrorMessage
+
+function logErrorMessage (er, summaryLevel, detailLevel) {
+  var msg = errorMessage(er)
+  msg.summary.forEach(function (logline) {
+    log[summaryLevel].apply(log, logline)
+  })
+  msg.detail.forEach(function (logline) {
+    log[detailLevel].apply(log, logline)
+  })
+  return msg
+}