chore: update dependencies - #107
Merged
Merged
Conversation
Continuation of #100
Contributor
Author
|
@arcanis do you know why using a patch version breaks the CI? |
Contributor
|
The patch file might be gitignored and need an override in the gitignore file 🤔 |
Contributor
|
Good thing you disabled vm2, it had a vulnerability: https://security.snyk.io/package/npm/vm2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on #100, I noticed updating
proxy-agentwas blocked by some issue, so I left the outdated version in the other PR that was big enough as is.Turned out the reason was upgrading
proxy-agentaddsvm2to the dependency tree (even though it's never actually used, at least not by the APIs Corepack uses), and it seems that something betweenvm2, Webpack, and PnP is not behaving as expected and the build fails. I usedyarn patchto basically remove all ofvm2code to replace it by some minimal mock file, and now Webpack doesn't freak out, and the tests are passing.I've also bumped the other packages that were left over, and the Yarn version itself.