fix(ci): resolve secrets context error and python version extraction (#236)

<!-- markdownlint-disable-next-line first-line-heading -->
## Description

correct secrets context usage and python version extraction

## Context

- Change GPG signing conditional to use env.APP_SIGNING_KEY instead of
secrets context to avoid parse error
- Fix python_version grep pattern (was duplicating nodejs version)

## Type of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply. -->

- [ ] Refactoring (non-breaking change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would change existing
functionality)
- [X] Bug fix (non-breaking change which fixes an issue)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply. -->

- [X] I am familiar with the [contributing
guidelines](../docs/CONTRIBUTING.md)
- [X] I have followed the code style of the project
- [ ] I have added tests to cover my changes
- [X] I have updated the documentation accordingly
- [ ] This PR is a result of pair or mob programming

---

## Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others
privacy, we kindly ask you to NOT including [PII (Personal Identifiable
Information) / PID (Personal Identifiable
Data)](https://digital.nhs.uk/data-and-information/keeping-data-safe-and-benefitting-the-public)
or any other sensitive data in this PR (Pull Request) and the codebase
changes. We will remove any PR that do contain any sensitive
information. We really appreciate your cooperation in this matter.

- [X] I confirm that neither PII/PID nor sensitive data are included in
this PR and the codebase changes.

Author: walteck

.github/workflows/cicd-2-publish.yaml

@@ -34,7 +34,7 @@ jobs:
           echo "build_timestamp=$(date --date=$datetime -u +'%Y%m%d%H%M%S')" >> $GITHUB_OUTPUT
           echo "build_epoch=$(date --date=$datetime -u +'%s')" >> $GITHUB_OUTPUT
           echo "nodejs_version=$(grep "^nodejs" .tool-versions | cut -f2 -d' ')" >> $GITHUB_OUTPUT
-          echo "python_version=$(grep "^nodejs" .tool-versions | cut -f2 -d' ')" >> $GITHUB_OUTPUT
+          echo "python_version=$(grep "^python" .tool-versions | cut -f2 -d' ')" >> $GITHUB_OUTPUT
           echo "terraform_version=$(grep "^terraform" .tool-versions | cut -f2 -d' ')" >> $GITHUB_OUTPUT
       - name: "List variables"
         run: |
@@ -64,7 +64,8 @@ jobs:
           app-id: ${{ secrets.APP_ID }}
           private-key: ${{ secrets.APP_PRIVATE_KEY }}
       - name: "Import GPG key and configure signing"
-        if: ${{ secrets.APP_SIGNING_KEY != '' }}
+        # Use env context for conditional check; secrets context not available in 'if' here without proper expression parsing.
+        if: ${{ env.APP_SIGNING_KEY != '' }}
         env:
           APP_SIGNING_KEY: ${{ secrets.APP_SIGNING_KEY }}
           GPG_KEY_ID: ${{ secrets.APP_SIGNING_KEY_ID }}

docs/developer-guides/Release_Signing_and_GitHub_App.md

@@ -143,7 +143,7 @@ Record:
 ## 5. Export Keys and Create Revocation Certificate
 
 ```bash
-KEY_ID="ABC123DEF456789A"  # Replace with your key ID
+KEY_ID="<YOUR_KEY_ID_HERE>"  # Replace with your actual GPG key ID
 FPR="<REPLACE_WITH_FULL_FINGERPRINT>"
 
 # Public key (for GitHub App)

scripts/config/gitleaks.toml

@@ -16,10 +16,14 @@ regexes = [
 ]
 
 [allowlist]
+description = "Global allowlist for false positives"
 paths = [
   '''dist/index.js.map''',
   '''dist/index.js''',
   '''.terraform.lock.hcl''',
   '''poetry.lock''',
   '''yarn.lock''',
 ]
+stopwords = [
+  '''ABC123DEF456789A''',  # Documentation placeholder for GPG key ID
+]