Reverted back to original ifelse

Signed-off-by: Melvin Suter <github@damon.ch>

Author: melvin-suter

lib/smb.php

@@ -41,26 +41,28 @@ private function tryAuthentication($uid, $password) {
 		$password = escapeshellarg($password);
 		$command = self::SMBCLIENT.' '.escapeshellarg('//' . $this->host . '/dummy').' -U '.$uidEscaped.'%'.$password;
 		$lastline = exec($command, $output, $retval);
-
-		if ( $retval === 0 || strpos($lastline, 'NT_STATUS_BAD_NETWORK_NAME') !== false ) {
-		    return $uid;
-		} else {
-			switch($retval) {
-				case 127:
-					OC::$server->getLogger()->error(
-						'ERROR: smbclient executable missing',
-						['app' => 'user_external']
-					);        
-					break;
-				default:
-					OC::$server->getLogger()->error(    
-						'ERROR: smbclient error: ' . trim($lastline),
-						['app' => 'user_external']  
-					);
-					break;
-
-			}
+		if ($retval === 127) {
+			OC::$server->getLogger()->error(
+				'ERROR: smbclient executable missing',
+				['app' => 'user_external']
+			);
+			return false;
+		} else if (strpos($lastline, self::LOGINERROR) !== false) {
+			//normal login error
 			return false;
+		} else if (strpos($lastline, 'NT_STATUS_BAD_NETWORK_NAME') !== false) {
+			//login on minor error
+			goto login;
+		} else if ($retval !== 0) {
+			//some other error
+			OC::$server->getLogger()->error(
+				'ERROR: smbclient error: ' . trim($lastline),
+				['app' => 'user_external']
+			);
+			return false;
+		} else {
+			login:
+			return $uid;
 		}
 	}