chore(cleanup): sync and save service are always defined now

Signed-off-by: Max <max@nextcloud.com>

Author: max-nextcloud

cypress/support/sessions.js

@@ -10,12 +10,12 @@ import { open } from '../../src/apis/Connect.ts'
 const url = Cypress.config('baseUrl').replace(/\/index.php\/?$/g, '')
 
 Cypress.Commands.add('createTextSession', async (fileId, options = {}) => {
-	const { data } = await open({ fileId, ...options })
+	const { data } = await open({ fileId, token: options.shareToken, ...options })
 	return new Connection({ data }, options)
 })
 
 Cypress.Commands.add('failToCreateTextSession', (fileId, baseVersionEtag = null, options = {}) => {
-	open({ fileId, ...options, baseVersionEtag })
+	return open({ fileId, ...options, baseVersionEtag })
 		.then((_response) => {
 			throw new Error('Expected request to fail - but it succeeded!')
 		}, (err) => err.response)

src/components/CollisionResolveDialog.vue

@@ -65,15 +65,15 @@ export default {
 	methods: {
 		resolveThisVersion() {
 			this.clicked = true
-			this.saveService?.forceSave().then(() => this.syncService?.syncUp())
+			this.saveService.forceSave().then(() => this.syncService.syncUp())
 			this.setEditable(!this.readOnly)
 		},
 		resolveServerVersion() {
 			const { outsideChange } = this.syncError.data
 			this.clicked = true
 			this.setEditable(!this.readOnly)
 			this.setContent(outsideChange)
-			this.saveService?.forceSave().then(() => this.syncService?.syncUp())
+			this.saveService.forceSave().then(() => this.syncService.syncUp())
 		},
 	},
 }

src/components/Editor.vue

@@ -821,7 +821,7 @@ export default defineComponent({
 				pendingStructs: this.ydoc.store.pendingStructs,
 				pendingStructsRemote: this.syncProvider?.remote.store.pendingStructs,
 				clientVectors: [],
-				documentState: this.saveService?.getDocumentState(),
+				documentState: this.saveService.getDocumentState(),
 			}
 			for (const client of this.ydoc.store.clients.values()) {
 				yjsData.clientVectors.push(client.at(-1).id)
@@ -885,7 +885,7 @@ export default defineComponent({
 		},
 
 		saveBeforeUnload() {
-			this.saveService?.saveViaSendBeacon()
+			this.saveService.saveViaSendBeacon()
 		},
 	},
 })

src/components/Editor/GuestNameDialog.vue

@@ -56,13 +56,13 @@ export default {
 		},
 	},
 	beforeMount() {
-		this.guestName = this.syncService?.guestName
+		this.guestName = this.syncService.guestName
 		this.updateBufferedGuestName()
 	},
 	methods: {
 		setGuestName() {
-			const previousGuestName = this.syncService?.guestName
-			this.syncService?.updateSession(this.guestName).then(() => {
+			const previousGuestName = this.syncService.guestName
+			this.syncService.updateSession(this.guestName).then(() => {
 				localStorage.setItem('nick', this.guestName)
 				this.updateBufferedGuestName()
 			}).catch((e) => {

src/components/Editor/MediaHandler.vue

@@ -134,7 +134,7 @@ export default {
 		async uploadAttachmentFile(file, position = null) {
 			this.state.isUploadingAttachments = true
 
-			return this.syncService?.uploadAttachment(file)
+			return this.syncService.uploadAttachment(file)
 				.then((response) => {
 					this.insertAttachment(
 						response.data?.name, response.data?.id, file.type,
@@ -168,7 +168,7 @@ export default {
 
 			this.state.isUploadingAttachments = true
 
-			return this.syncService?.insertAttachmentFile(filePath).then((response) => {
+			return this.syncService.insertAttachmentFile(filePath).then((response) => {
 				this.insertAttachment(
 					response.data?.name, response.data?.id, response.data?.mimetype,
 					null, response.data?.dirname,
@@ -182,7 +182,7 @@ export default {
 		},
 		createAttachment(template) {
 			this.state.isUploadingAttachments = true
-			return this.syncService?.createAttachment(template).then((response) => {
+			return this.syncService.createAttachment(template).then((response) => {
 				this.insertAttachmentPreview(response.data?.id)
 			}).catch((error) => {
 				logger.error('Failed to create attachment', { error })

src/components/Editor/Status.vue

@@ -130,7 +130,7 @@ export default {
 	methods: {
 		onClickSave() {
 			if (this.dirtyStateIndicator) {
-				this.saveService?.forceSave()
+				this.saveService.forceSave()
 			}
 		},
 		onEditorWidthChange(newWidth) {

src/components/Menu/ActionAttachmentUpload.vue

@@ -111,7 +111,7 @@ export default {
 			return loadState('files', 'templates', [])
 		},
 		isUploadDisabled() {
-			return !this.syncService?.hasOwner
+			return !this.syncService.hasOwner
 		},
 		menuTitle() {
 			return this.isUploadDisabled

src/components/SuggestionsBar.vue

@@ -102,7 +102,7 @@ export default {
 			return this.$file?.relativePath ?? '/'
 		},
 		isUploadDisabled() {
-			return !this.syncService?.hasOwner
+			return !this.syncService.hasOwner
 		},
 		uploadTitle() {
 			return (