Skip to content

fix(core): keep the header search input in document flow#61668

Merged
artonge merged 1 commit into
masterfrom
fix/search-input-document-flow
Jun 30, 2026
Merged

fix(core): keep the header search input in document flow#61668
artonge merged 1 commit into
masterfrom
fix/search-input-document-flow

Conversation

@pringelmann

@pringelmann pringelmann commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

The unified search trigger was absolutely positioned to center it in the header, which placed it after the right-hand items in the DOM. Tab order no longer matched the visual order (the app-injected Assistant button tabbed before search)

This moves the #unified-search mount into a dedicated header-center zone and centers it with symmetric flexbox, instead of absolute positioning. The centering is scoped so behaviour elsewhere is unchanged.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Screenshots before/after for front-end changes
  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable (ex: critical bugfixes)
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@pringelmann pringelmann requested review from a team as code owners June 30, 2026 10:36
@pringelmann pringelmann requested review from Altahrim, nfebe, salmart-dev, sorbaugh and susnux and removed request for a team June 30, 2026 10:36
@pringelmann pringelmann self-assigned this Jun 30, 2026
@pringelmann pringelmann added this to the Nextcloud 35 milestone Jun 30, 2026
@pringelmann pringelmann added bug design Design, UI, UX, etc. 3. to review Waiting for reviews accessibility labels Jun 30, 2026
@susnux

susnux commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

That breaks tab order (DOM position no longer matches visual position)

Well I think the problem is that the assistant is not mounting it self correctly.

Comment thread core/css/header.scss Outdated
@pringelmann

Copy link
Copy Markdown
Contributor Author

That breaks tab order (DOM position no longer matches visual position)

Well I think the problem is that the assistant is not mounting it self correctly.

Yes that too :) but either way the absolute positioning creates problems for the elements around it

@susnux

susnux commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

but either way the absolute positioning creates problems for the elements around it

Sure!

But how do you properly center the element when left and right have different sizes?
As it should be absolutely centered, no?

What if size > 512px but appname is very long?

@pringelmann pringelmann force-pushed the fix/search-input-document-flow branch from b21472b to 715696f Compare June 30, 2026 11:10
@pringelmann

Copy link
Copy Markdown
Contributor Author

but either way the absolute positioning creates problems for the elements around it

Sure!

But how do you properly center the element when left and right have different sizes? As it should be absolutely centered, no?

What if size > 512px but appname is very long?

Both side areas are flex: 1 0, so they're always equal width regardless of content, which keeps the search on the true midline, not just centered in the leftover space. So it is absolutely centered.

A long appname doesn't shift it either. And now that the input is in flow, the label can ellipsize at the header-start edge instead of running under the search:

resize.mp4

That truncation is a small follow-up, but it's only possible because we dropped the absolute positioning.

@pringelmann pringelmann force-pushed the fix/search-input-document-flow branch from 715696f to 9eee209 Compare June 30, 2026 12:30
@pringelmann pringelmann requested a review from artonge June 30, 2026 12:31
@pringelmann

Copy link
Copy Markdown
Contributor Author

/compile rebase

Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann pringelmann force-pushed the fix/search-input-document-flow branch from 9eee209 to 3c39515 Compare June 30, 2026 14:31
@artonge artonge merged commit fc52f6f into master Jun 30, 2026
192 of 200 checks passed
@artonge artonge deleted the fix/search-input-document-flow branch June 30, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews accessibility bug design Design, UI, UX, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove absolute positioning from the header search input

3 participants