fix(core): resolve some edge cases with recommended apps#61663
Conversation
There are some edge cases to keep in mind: 1. Not always install the code server if office is not installed 2. Handle installed apps properly 3. Properly handle aborted password confirmation Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
Could be folded in here since you already touch this flow. Happy to pick it up if you're busy, just let me know. |
|
@susnux The per-app enable loop here reintroduces multiple password prompts. #60068 switched install to a single bulk enable specifically so strict confirmation only prompts once. Installing N recommended apps now pops N password dialogs. That's also why the setup.ts Cypress spec is red: it expects one bulk enable + one dialog. How do you want to handle it? |
Sounds like we should bring that back, but that needs backend changes now. But the cypress test I can adjust here for now. |
|
Related bug: #32310 |
Summary
There are some edge cases to keep in mind:
Checklist
3. to review, feature component)stable32)AI (if applicable)