Skip to content

Commit f5b9663

Browse files
committed
fix(unified-search): Remove hard-coded search result limit
A changed in #45317 introduced a hard stop (25) that prevents full search results from showing up. If there are more than 25 search results for a query only 25 can be seen. So two main issues: - Only 25 results can be seen in total no matter what. - Breaks web client pagination, which typically adds 5 results per request. Signed-off-by: nfebe <fenn25.fn@gmail.com>
1 parent d36fc65 commit f5b9663

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

core/Controller/UnifiedSearchController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public function getProviders(string $from = ''): DataResponse {
7272
* @param string $providerId ID of the provider
7373
* @param string $term Term to search
7474
* @param int|null $sortOrder Order of entries
75-
* @param int|null $limit Maximum amount of entries, limited to 25
75+
* @param int|null $limit Maximum amount of entries
7676
* @param int|string|null $cursor Offset for searching
7777
* @param string $from The current user URL
7878
*
@@ -96,7 +96,7 @@ public function search(
9696
[$route, $routeParameters] = $this->getRouteInformation($from);
9797

9898
$limit ??= SearchQuery::LIMIT_DEFAULT;
99-
$limit = max(1, min($limit, 25));
99+
$limit = max(1, $limit);
100100

101101
try {
102102
$filters = $this->composer->buildFilterList($providerId, $this->request->getParams());

core/openapi-full.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8511,7 +8511,7 @@
85118511
{
85128512
"name": "limit",
85138513
"in": "query",
8514-
"description": "Maximum amount of entries, limited to 25",
8514+
"description": "Maximum amount of entries",
85158515
"schema": {
85168516
"type": "integer",
85178517
"format": "int64",

core/openapi.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8511,7 +8511,7 @@
85118511
{
85128512
"name": "limit",
85138513
"in": "query",
8514-
"description": "Maximum amount of entries, limited to 25",
8514+
"description": "Maximum amount of entries",
85158515
"schema": {
85168516
"type": "integer",
85178517
"format": "int64",

openapi.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12024,7 +12024,7 @@
1202412024
{
1202512025
"name": "limit",
1202612026
"in": "query",
12027-
"description": "Maximum amount of entries, limited to 25",
12027+
"description": "Maximum amount of entries",
1202812028
"schema": {
1202912029
"type": "integer",
1203012030
"format": "int64",

0 commit comments

Comments
 (0)