Skip to content

Commit f212638

Browse files
authored
Merge pull request #42495 from nextcloud/stable28-fix/a11y/personal-info-headings
2 parents 6a09055 + e1d1491 commit f212638

4 files changed

Lines changed: 6 additions & 13 deletions

File tree

apps/settings/src/components/PersonalInfo/AvatarSection.vue

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
<h3 class="hidden-visually">
2626
{{ t('settings', 'Your profile information') }}
2727
</h3>
28-
<HeaderBar :input-id="avatarChangeSupported ? inputId : null"
28+
<HeaderBar :is-heading="true"
2929
:readable="avatar.readable"
3030
:scope.sync="avatar.scope" />
3131

@@ -63,8 +63,7 @@
6363
</NcButton>
6464
</div>
6565
<span>{{ t('settings', 'The file must be a PNG or JPG') }}</span>
66-
<input :id="inputId"
67-
ref="input"
66+
<input ref="input"
6867
type="file"
6968
:accept="validMimeTypes.join(',')"
7069
@change="onChange">
@@ -163,12 +162,6 @@ export default {
163162
}
164163
},
165164
166-
computed: {
167-
inputId() {
168-
return `account-property-${this.avatar.name}`
169-
},
170-
},
171-
172165
created() {
173166
subscribe('settings:display-name:updated', this.handleDisplayNameUpdate)
174167
},

apps/settings/src/components/PersonalInfo/ProfileSection/ProfileSection.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
<template>
2424
<section>
25-
<HeaderBar :readable="propertyReadable" />
25+
<HeaderBar :is-heading="true" :readable="propertyReadable" />
2626

2727
<ProfileCheckbox :profile-enabled.sync="profileEnabled" />
2828

dist/settings-vue-settings-personal-info.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/settings-vue-settings-personal-info.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)