fix: show file size on remote shares

grnd-alt · grnd-alt · commit e4dcec8d5fab · 2026-02-18T15:11:59.000+01:00
Signed-off-by: grnd-alt &lt;git@belakkaf.net&gt;
diff --git a/apps/files_sharing/lib/Controller/RemoteController.php b/apps/files_sharing/lib/Controller/RemoteController.php
@@ -124,6 +124,7 @@ private function extendShareInfo(ExternalShare $share): array {
 		$shareData['permissions'] = $mountPointNode->getPermissions();
 		$shareData['type'] = $mountPointNode->getType();
 		$shareData['file_id'] = $mountPointNode->getId();
+		$shareData['item_size'] = $mountPointNode->getSize();
 
 		return $shareData;
 	}
diff --git a/apps/files_sharing/lib/External/ExternalShare.php b/apps/files_sharing/lib/External/ExternalShare.php
@@ -112,6 +112,7 @@ public function jsonSerialize(): array {
 			'permissions' => null,
 			'mtime' => null,
 			'type' => null,
+			'item_size' => null,
 		];
 	}
 
diff --git a/apps/files_sharing/lib/ResponseDefinitions.php b/apps/files_sharing/lib/ResponseDefinitions.php
@@ -97,6 +97,7 @@
  *     share_type: int,
  *     type: string|null,
  *     user: string,
+ *     item_size: int|float|null,
  * }
  *
  * @psalm-type Files_SharingSharee = array{
diff --git a/apps/files_sharing/openapi.json b/apps/files_sharing/openapi.json
@@ -407,7 +407,8 @@
                     "share_token",
                     "share_type",
                     "type",
-                    "user"
+                    "user",
+                    "item_size"
                 ],
                 "properties": {
                     "accepted": {
@@ -468,6 +469,19 @@
                     },
                     "user": {
                         "type": "string"
+                    },
+                    "item_size": {
+                        "nullable": true,
+                        "anyOf": [
+                            {
+                                "type": "integer",
+                                "format": "int64"
+                            },
+                            {
+                                "type": "number",
+                                "format": "double"
+                            }
+                        ]
                     }
                 }
             },
diff --git a/openapi.json b/openapi.json
@@ -2526,7 +2526,8 @@
                     "share_token",
                     "share_type",
                     "type",
-                    "user"
+                    "user",
+                    "item_size"
                 ],
                 "properties": {
                     "accepted": {
@@ -2587,6 +2588,19 @@
                     },
                     "user": {
                         "type": "string"
+                    },
+                    "item_size": {
+                        "nullable": true,
+                        "anyOf": [
+                            {
+                                "type": "integer",
+                                "format": "int64"
+                            },
+                            {
+                                "type": "number",
+                                "format": "double"
+                            }
+                        ]
                     }
                 }
             },

Original file line number	Diff line number	Diff line change
`@@ -124,6 +124,7 @@ private function extendShareInfo(ExternalShare $share): array {`
`124`	`124`	`$shareData['permissions'] = $mountPointNode->getPermissions();`
`125`	`125`	`$shareData['type'] = $mountPointNode->getType();`
`126`	`126`	`$shareData['file_id'] = $mountPointNode->getId();`
	`127`	`+ $shareData['item_size'] = $mountPointNode->getSize();`
`127`	`128`
`128`	`129`	`return $shareData;`
`129`	`130`	`}`
Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,7 @@ public function jsonSerialize(): array {`
`112`	`112`	`'permissions' => null,`
`113`	`113`	`'mtime' => null,`
`114`	`114`	`'type' => null,`
	`115`	`+ 'item_size' => null,`
`115`	`116`	`];`
`116`	`117`	`}`
`117`	`118`
Original file line number	Diff line number	Diff line change
`@@ -97,6 +97,7 @@`
`97`	`97`	`* share_type: int,`
`98`	`98`	`* type: string\|null,`
`99`	`99`	`* user: string,`
	`100`	`+ * item_size: int\|float\|null,`
`100`	`101`	`* }`
`101`	`102`	`*`
`102`	`103`	`* @psalm-type Files_SharingSharee = array{`