Skip to content

Commit bb6de2a

Browse files
committed
Allow target="_blank" in app navigation items
Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
1 parent 36b6a7c commit bb6de2a

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

core/src/components/AppMenu.vue

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,9 @@
3131
:class="{ 'has-unread': app.unread > 0 }"
3232
:aria-label="appLabel(app)"
3333
:title="app.name"
34-
:aria-current="app.active ? 'page' : false">
34+
:aria-current="app.active ? 'page' : false"
35+
:target="app.target ? '_blank' : undefined"
36+
:rel="app.target ? 'noopener noreferrer' : undefined">
3537
<img :src="app.icon" alt="">
3638
<div class="app-menu-entry--label">
3739
{{ app.name }}

dist/core-main.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-main.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)