Merge pull request #59303 from nextcloud/bugfix/noid/dont-redirect-on-error

nickvergessen · web-flow · commit b119cace4fc3 · 2026-03-30T13:12:48.000+02:00
fix(sharing): Don't redirect when accepting a share failed
diff --git a/apps/files_sharing/lib/Controller/AcceptController.php b/apps/files_sharing/lib/Controller/AcceptController.php
@@ -51,7 +51,7 @@ public function accept(string $shareId): Response {
 		try {
 			$share = $this->shareManager->acceptShare($share, $user->getUID());
 		} catch (\Exception $e) {
-			// Just ignore
+			return new NotFoundResponse();
 		}
 
 		$url = $this->urlGenerator->linkToRouteAbsolute('files.viewcontroller.showFile', ['fileid' => $share->getNode()->getId()]);

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public function accept(string $shareId): Response {`
`51`	`51`	`try {`
`52`	`52`	`$share = $this->shareManager->acceptShare($share, $user->getUID());`
`53`	`53`	`} catch (\Exception $e) {`
`54`		`- // Just ignore`
	`54`	`+ return new NotFoundResponse();`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`$url = $this->urlGenerator->linkToRouteAbsolute('files.viewcontroller.showFile', ['fileid' => $share->getNode()->getId()]);`