Skip to content

Commit ae0a496

Browse files
Bump jquery from 2.2.4 to 3.1.0
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
1 parent 25f8d76 commit ae0a496

29 files changed

Lines changed: 459 additions & 381 deletions

apps/files/js/dist/sidebar.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/files/js/dist/sidebar.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/files/js/filelist.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3699,7 +3699,7 @@
36993699
const enabled = tabView.canDisplay || undefined
37003700
if (tabView.id) {
37013701
OCA.Files.Sidebar.registerTab(new OCA.Files.Sidebar.Tab({
3702-
id: tabView.id,
3702+
id: tabView.id,
37033703
name: tabView.getLabel(),
37043704
icon: tabView.getIcon(),
37053705
mount: function(el, fileInfo) {

apps/files/tests/js/breadcrumbSpec.js

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -207,35 +207,6 @@ describe('OCA.Files.BreadCrumb tests', function() {
207207
bc = null;
208208
});
209209

210-
it('Opens and closes the menu on click', function() {
211-
// Menu exists
212-
expect($popovermenu.length).toEqual(1);
213-
214-
// Disable jQuery delay
215-
jQuery.fx.off = true
216-
217-
// Click on menu
218-
$crumbmenuLink.click();
219-
expect($popovermenu.is(':visible')).toEqual(true);
220-
221-
// Click on home
222-
$(document).mouseup();
223-
expect($popovermenu.is(':visible')).toEqual(false);
224-
225-
// Change directory and reset elements
226-
bc.setDirectory('/one/two/three/four/five/six/seven/eight/nine/ten');
227-
$crumbmenuLink = bc.$el.find('.crumbmenu > a');
228-
$popovermenu = $crumbmenuLink.next('.popovermenu');
229-
230-
// Click on menu again
231-
$crumbmenuLink.click();
232-
expect($popovermenu.is(':visible')).toEqual(true);
233-
234-
// Click on home again
235-
$(document).mouseup();
236-
expect($popovermenu.is(':visible')).toEqual(false);
237-
238-
});
239210
it('Shows only items not in the breadcrumb', function() {
240211
var hiddenCrumbs = bc.$el.find('.crumb:not(.crumbmenu).hidden');
241212
expect($popovermenu.find('li:not(.in-breadcrumb)').length).toEqual(hiddenCrumbs.length);

apps/files/tests/js/favoritesfilelistspec.js

Lines changed: 22 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ describe('OCA.Files.FavoritesFileList tests', function() {
5858
fileList.destroy();
5959
fileList = undefined;
6060
});
61-
it('render files', function() {
61+
it('render files', function(done) {
6262
var deferred = $.Deferred();
6363
fetchStub.returns(deferred.promise());
6464

@@ -77,23 +77,27 @@ describe('OCA.Files.FavoritesFileList tests', function() {
7777
mimetype: 'text/plain'
7878
}]);
7979

80-
var $rows = fileList.$el.find('tbody tr');
81-
var $tr = $rows.eq(0);
82-
expect($rows.length).toEqual(1);
83-
expect($tr.attr('data-id')).toEqual('7');
84-
expect($tr.attr('data-type')).toEqual('file');
85-
expect($tr.attr('data-file')).toEqual('test.txt');
86-
expect($tr.attr('data-path')).toEqual('/somedir');
87-
expect($tr.attr('data-size')).toEqual('123');
88-
expect(parseInt($tr.attr('data-permissions'), 10))
89-
.toEqual(OC.PERMISSION_ALL);
90-
expect($tr.attr('data-mime')).toEqual('text/plain');
91-
expect($tr.attr('data-mtime')).toEqual('11111000');
92-
expect($tr.find('a.name').attr('href')).toEqual(
93-
OC.getRootPath() +
94-
'/remote.php/webdav/somedir/test.txt'
95-
);
96-
expect($tr.find('.nametext').text().trim()).toEqual('test.txt');
80+
setTimeout(function() {
81+
var $rows = fileList.$el.find('tbody tr');
82+
var $tr = $rows.eq(0);
83+
expect($rows.length).toEqual(1);
84+
expect($tr.attr('data-id')).toEqual('7');
85+
expect($tr.attr('data-type')).toEqual('file');
86+
expect($tr.attr('data-file')).toEqual('test.txt');
87+
expect($tr.attr('data-path')).toEqual('/somedir');
88+
expect($tr.attr('data-size')).toEqual('123');
89+
expect(parseInt($tr.attr('data-permissions'), 10))
90+
.toEqual(OC.PERMISSION_ALL);
91+
expect($tr.attr('data-mime')).toEqual('text/plain');
92+
expect($tr.attr('data-mtime')).toEqual('11111000');
93+
expect($tr.find('a.name').attr('href')).toEqual(
94+
OC.getRootPath() +
95+
'/remote.php/webdav/somedir/test.txt'
96+
);
97+
expect($tr.find('.nametext').text().trim()).toEqual('test.txt');
98+
99+
done();
100+
}, 0);
97101
});
98102
});
99103
});

apps/files/tests/js/fileUploadSpec.js

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ describe('OC.Upload tests', function() {
123123
});
124124
describe('Upload conflicts', function() {
125125
var conflictDialogStub;
126+
var clock;
126127
var fileList;
127128

128129
beforeEach(function() {
@@ -162,6 +163,11 @@ describe('OC.Upload tests', function() {
162163
deferred.resolve();
163164
});
164165
afterEach(function() {
166+
if (clock) {
167+
clock.restore();
168+
clock = undefined
169+
}
170+
165171
conflictDialogStub.restore();
166172

167173
fileList.destroy();
@@ -210,7 +216,7 @@ describe('OC.Upload tests', function() {
210216
expect(result[1].submit.calledOnce).toEqual(false);
211217
expect(result[2].submit.calledOnce).toEqual(true);
212218
done();
213-
}, 0);
219+
}, 10);
214220
});
215221
var result = addFiles(uploader, [
216222
{name: 'conflict.txt'},
@@ -251,8 +257,6 @@ describe('OC.Upload tests', function() {
251257
uploader.onReplace(upload);
252258
});
253259
it('autorenames file when choosing replace in conflict mode', function(done) {
254-
// needed for _.defer call
255-
var clock = sinon.useFakeTimers();
256260
var fileData = {name: 'conflict.txt'};
257261
var uploadData = addFiles(uploader, [
258262
fileData
@@ -272,15 +276,15 @@ describe('OC.Upload tests', function() {
272276
expect(uploadData[0].submit.calledOnce).toEqual(true);
273277
getResponseStatusStub.returns(412);
274278
uploader.fileUploadParam.fail.call($dummyUploader[0], {}, uploadData[0]);
275-
clock.tick(500);
276279
}
277280
if(counter===2)
278281
{
279-
expect(upload.getFileName()).toEqual('conflict (3).txt');
280-
expect(uploadData[0].submit.calledTwice).toEqual(true);
282+
_.defer(function() {
283+
expect(upload.getFileName()).toEqual('conflict (3).txt');
284+
expect(uploadData[0].submit.calledTwice).toEqual(true);
281285

282-
clock.restore();
283-
done();
286+
done();
287+
})
284288
}
285289
});
286290

0 commit comments

Comments
 (0)