fixup! Add logging to federation sync

Author: miaulalala

apps/dav/lib/CardDAV/SyncService.php

@@ -100,8 +100,9 @@ public function syncRemoteAddressBook($url, $userName, $addressBookUrl, $sharedS
 				// remote server revoked access to the address book, remove it
 				$this->backend->deleteAddressBook($addressBookId);
 				$this->logger->error('Authorization failed, remove address book: ' . $url, ['app' => 'dav']);
-				throw $ex;
 			}
+			$this->logger->error('Client exception:', ['app' => 'dav', 'exception' => $ex]);
+			throw $ex;
 		}
 
 		// 3. apply changes

apps/federation/lib/SyncFederationAddressBooks.php

@@ -95,10 +95,10 @@ public function syncThemAll(\Closure $callback) {
 			} catch (\Exception $ex) {
 				if ($ex->getCode() === Http::STATUS_UNAUTHORIZED) {
 					$this->dbHandler->setServerStatus($url, TrustedServers::STATUS_ACCESS_REVOKED);
-					$this->logger->error('Server sync failed because of revoked access',['exception' => $ex] );
+					$this->logger->error('Server sync failed because of revoked access.');
 				} else {
 					$this->dbHandler->setServerStatus($url, TrustedServers::STATUS_FAILURE);
-					$this->logger->error('Server sync failed', ['exception' => $ex]);
+					$this->logger->error('Server sync failed.');
 				}
 				$callback($url, $ex);
 			}

apps/federation/lib/SyncJob.php

@@ -26,20 +26,18 @@
 namespace OCA\Federation;
 
 use OC\BackgroundJob\TimedJob;
-use OCP\ILogger;
 use Psr\Log\LoggerInterface;
 
 class SyncJob extends TimedJob {
 
 	/** @var SyncFederationAddressBooks */
 	protected $syncService;
 
-	/** @var ILogger */
+	/** @var LoggerInterface */
 	protected $logger;
 
 	/**
 	 * @param SyncFederationAddressBooks $syncService
-	 * @param ILogger $logger
 	 */
 	public function __construct(SyncFederationAddressBooks $syncService, LoggerInterface $logger) {
 		// Run once a day