feat: Add a configuration toggle for lazy objects in DI

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Author: come-nc

config/config.sample.php

@@ -2743,4 +2743,12 @@
  * Defaults to true.
  */
 'files.trash.delete' => true,
+
+/**
+ * Enable lazy objects feature from PHP 8.4 to be used in the Dependency Injection.
+ * Should improve performances by avoiding buiding unused objects.
+ *
+ * Defaults to false.
+ */
+'enable_lazy_objects' => false,
 ];

lib/base.php

@@ -632,6 +632,9 @@ public static function init(): void {
 			exit();
 		}
 
+		// Enable lazy loading if activated
+		\OC\AppFramework\Utility\SimpleContainer::$useLazyObjects = (bool)self::$config->getValue('enable_lazy_objects');
+
 		// setup the basic server
 		self::$server = new \OC\Server(\OC::$WEBROOT, self::$config);
 		self::$server->boot();

lib/private/AppFramework/Utility/SimpleContainer.php

@@ -24,6 +24,8 @@
  * SimpleContainer is a simple implementation of a container on basis of Pimple
  */
 class SimpleContainer implements ArrayAccess, ContainerInterface, IContainer {
+	public static bool $useLazyObjects = false;
+
 	private Container $container;
 
 	public function __construct() {
@@ -58,7 +60,7 @@ private function buildClass(ReflectionClass $class): object {
 			/* No constructor, return a instance directly */
 			return $class->newInstance();
 		}
-		if (PHP_VERSION_ID >= 80400) {
+		if (PHP_VERSION_ID >= 80400 && self::$useLazyObjects) {
 			/* For PHP>=8.4, use a lazy ghost to delay constructor and dependency resolving */
 			/** @psalm-suppress UndefinedMethod */
 			return $class->newLazyGhost(function (object $object) use ($constructor): void {