Merge pull request #53021 from nextcloud/backport/52932/stable31

nickvergessen · web-flow · commit 64cb674f63d8 · 2025-05-22T13:13:09.000+02:00
[stable31] test: Speed up comments test
diff --git a/tests/lib/Comments/ManagerTest.php b/tests/lib/Comments/ManagerTest.php
@@ -1099,6 +1099,7 @@ public function testResolveDisplayNameInvalidType(): void {
 	 * @return IComment[]
 	 */
 	private function proccessComments(array $data): array {
+		$this->connection->beginTransaction();
 		/** @var IComment[] */
 		$comments = [];
 		foreach ($data as $comment) {
@@ -1114,6 +1115,7 @@ private function proccessComments(array $data): array {
 			$comment = $this->testSave($message, $actorId, $verb, $parentId, $id);
 			$comments[$comment->getMessage() . '#' . $comment->getActorId()] = $comment;
 		}
+		$this->connection->commit();
 		return $comments;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1099,6 +1099,7 @@ public function testResolveDisplayNameInvalidType(): void {`
`1099`	`1099`	`* @return IComment[]`
`1100`	`1100`	`*/`
`1101`	`1101`	`private function proccessComments(array $data): array {`
	`1102`	`+ $this->connection->beginTransaction();`
`1102`	`1103`	`/** @var IComment[] */`
`1103`	`1104`	`$comments = [];`
`1104`	`1105`	`foreach ($data as $comment) {`
`@@ -1114,6 +1115,7 @@ private function proccessComments(array $data): array {`
`1114`	`1115`	`$comment = $this->testSave($message, $actorId, $verb, $parentId, $id);`
`1115`	`1116`	`$comments[$comment->getMessage() . '#' . $comment->getActorId()] = $comment;`
`1116`	`1117`	`}`
	`1118`	`+ $this->connection->commit();`
`1117`	`1119`	`return $comments;`
`1118`	`1120`	`}`
`1119`	`1121`