Server error/hint pages with a 500 error code to avoid it being seen instead of the actual resource

MorrisJobke · MorrisJobke · commit 6186e83b7be2 · 2018-06-26T09:17:39.000+02:00
* found while reviewing #7205 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
diff --git a/lib/private/legacy/template.php b/lib/private/legacy/template.php
@@ -317,6 +317,7 @@ public static function printErrorPage( $error_msg, $hint = '' ) {
 			$hint = '';
 		}
 
+		header(self::getHttpProtocol() . ' 500 Internal Server Error');
 		try {
 			$content = new \OC_Template( '', 'error', 'error', false );
 			$errors = array(array('error' => $error_msg, 'hint' => $hint));
@@ -327,7 +328,6 @@ public static function printErrorPage( $error_msg, $hint = '' ) {
 			$logger->error("$error_msg $hint", ['app' => 'core']);
 			$logger->logException($e, ['app' => 'core']);
 
-			header(self::getHttpProtocol() . ' 500 Internal Server Error');
 			header('Content-Type: text/plain; charset=utf-8');
 			print("$error_msg $hint");
 		}

Original file line number	Diff line number	Diff line change
`@@ -317,6 +317,7 @@ public static function printErrorPage( $error_msg, $hint = '' ) {`
`317`	`317`	`$hint = '';`
`318`	`318`	`}`
`319`	`319`
	`320`	`+ header(self::getHttpProtocol() . ' 500 Internal Server Error');`
`320`	`321`	`try {`
`321`	`322`	`$content = new \OC_Template( '', 'error', 'error', false );`
`322`	`323`	`$errors = array(array('error' => $error_msg, 'hint' => $hint));`
`@@ -327,7 +328,6 @@ public static function printErrorPage( $error_msg, $hint = '' ) {`
`327`	`328`	`$logger->error("$error_msg $hint", ['app' => 'core']);`
`328`	`329`	`$logger->logException($e, ['app' => 'core']);`
`329`	`330`
`330`		`- header(self::getHttpProtocol() . ' 500 Internal Server Error');`
`331`	`331`	`header('Content-Type: text/plain; charset=utf-8');`
`332`	`332`	`print("$error_msg $hint");`
`333`	`333`	`}`