fix: make sure all mounts are setup in getById

Signed-off-by: Robin Appelman <robin@icewind.nl>

Author: icewind1991

lib/private/Files/Node/Root.php

@@ -19,6 +19,7 @@
 use OCP\Cache\CappedMemoryCache;
 use OCP\EventDispatcher\IEventDispatcher;
 use OCP\Files\Cache\ICacheEntry;
+use OCP\Files\Config\ICachedMountInfo;
 use OCP\Files\Config\IUserMountCache;
 use OCP\Files\Events\Node\FilesystemTornDownEvent;
 use OCP\Files\IRootFolder;
@@ -405,6 +406,7 @@ public function getFirstNodeByIdInPath(int $id, string $path): ?INode {
 	 */
 	public function getByIdInPath(int $id, string $path): array {
 		$mountCache = $this->getUserMountCache();
+		$setupManager = $this->mountManager->getSetupManager();
 		if ($path !== '' && strpos($path, '/', 1) > 0) {
 			[, $user] = explode('/', $path);
 		} else {
@@ -414,7 +416,7 @@ public function getByIdInPath(int $id, string $path): array {
 
 		// if the mount isn't in the cache yet, perform a setup first, then try again
 		if (count($mountsContainingFile) === 0) {
-			$this->mountManager->getSetupManager()->setupForPath($path, true);
+			$setupManager->setupForPath($path, true);
 			$mountsContainingFile = $mountCache->getMountsForFileId($id, $user);
 		}
 
@@ -436,11 +438,7 @@ public function getByIdInPath(int $id, string $path): array {
 		}, $mountsContainingFile));
 		$mountRoots = array_combine($mountRootIds, $mountRootPaths);
 
-		$mounts = $this->mountManager->getMountsByMountProvider($path, $mountProviders);
-
-		$mountsContainingFile = array_filter($mounts, function ($mount) use ($mountRoots) {
-			return isset($mountRoots[$mount->getStorageRootId()]);
-		});
+		$mountsContainingFile = array_map($this->mountManager->getMountFromMountInfo(...), $mountsContainingFile);
 
 		if (count($mountsContainingFile) === 0) {
 			if ($user === $this->getAppDataDirectoryName()) {