Skip to content

Commit 5507c27

Browse files
committed
fixup! fix: adapt rename action tests to check for parent permissions
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
1 parent 8596f38 commit 5507c27

2 files changed

Lines changed: 10 additions & 17 deletions

File tree

apps/files/src/actions/renameAction.spec.ts

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,29 +6,17 @@ import { action } from './renameAction'
66
import { File, Folder, Permission, View, FileAction } from '@nextcloud/files'
77
import * as eventBus from '@nextcloud/event-bus'
88
import { describe, expect, test, vi, beforeEach } from 'vitest'
9-
import { setActivePinia, createPinia, type Pinia } from 'pinia'
109
import { useFilesStore } from '../store/files'
11-
declare global {
12-
interface Window {
13-
_nc_files_pinia: Pinia
14-
}
15-
}
16-
17-
let files: ReturnType<typeof useFilesStore>
18-
let root: Folder & { _children?: string[] }
10+
import { getPinia } from '../store/index.ts'
1911

2012
const view = {
2113
id: 'files',
2214
name: 'Files',
2315
} as View
2416

2517
beforeEach(() => {
26-
const pinia = createPinia()
27-
setActivePinia(pinia)
28-
window._nc_files_pinia = pinia
29-
30-
root = new Folder({ owner: 'test', source: 'https://cloud.domain.com/remote.php/dav/files/admin/', id: 1, permissions: Permission.CREATE })
31-
files = useFilesStore()
18+
const root = new Folder({ owner: 'test', source: 'https://cloud.domain.com/remote.php/dav/files/admin/', id: 1, permissions: Permission.CREATE })
19+
const files = useFilesStore(getPinia())
3220
files.setRoot({ service: 'files', root })
3321
})
3422

apps/files/src/services/HotKeysService.spec.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,14 @@
22
* SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
33
* SPDX-License-Identifier: AGPL-3.0-or-later
44
*/
5-
import { File, Permission, View } from '@nextcloud/files'
5+
import { File, Folder, Permission, View } from '@nextcloud/files'
66
import { describe, it, vi, expect, beforeEach, beforeAll, afterEach } from 'vitest'
77
import { nextTick } from 'vue'
88
import axios from '@nextcloud/axios'
99

1010
import { getPinia } from '../store/index.ts'
1111
import { useActiveStore } from '../store/active.ts'
12+
import { useFilesStore } from '../store/files'
1213

1314
import { action as deleteAction } from '../actions/deleteAction.ts'
1415
import { action as favoriteAction } from '../actions/favoriteAction.ts'
@@ -49,13 +50,17 @@ describe('HotKeysService testing', () => {
4950

5051
// Make sure the file is reset before each test
5152
file = new File({
52-
id: 1,
53+
id: 2,
5354
source: 'https://cloud.domain.com/remote.php/dav/files/admin/foobar.txt',
5455
owner: 'admin',
5556
mime: 'text/plain',
5657
permissions: Permission.ALL,
5758
})
5859

60+
const root = new Folder({ owner: 'test', source: 'https://cloud.domain.com/remote.php/dav/files/admin/', id: 1, permissions: Permission.CREATE })
61+
const files = useFilesStore(getPinia())
62+
files.setRoot({ service: 'files', root })
63+
5964
// Setting the view first as it reset the active node
6065
activeStore.activeView = view
6166
activeStore.activeNode = file

0 commit comments

Comments
 (0)