Skip to content

Commit 434c5ba

Browse files
committed
PHP 7.4 excludes the arguments from stack traces by default.
That leads to a false positive is not setup via query() but directly warning for every app because the check does not work anymore. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
1 parent 8d5404b commit 434c5ba

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

lib/public/AppFramework/App.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,8 @@ public static function buildAppNamespace(string $appId, string $topNamespace='OC
7878
*/
7979
public function __construct(string $appName, array $urlParams = []) {
8080
if (\OC::$server->getConfig()->getSystemValueBool('debug')) {
81+
$oldExceptionIgonoreArs = ini_set('zend.exception_ignore_args', '0');
82+
8183
$applicationClassName = get_class($this);
8284
$e = new \RuntimeException('App class ' . $applicationClassName . ' is not setup via query() but directly');
8385
$setUpViaQuery = false;
@@ -105,6 +107,8 @@ public function __construct(string $appName, array $urlParams = []) {
105107
'app' => $appName,
106108
]);
107109
}
110+
111+
ini_set('zend.exception_ignore_args', $oldExceptionIgonoreArs);
108112
}
109113

110114
try {

0 commit comments

Comments
 (0)