Merge pull request #47069 from nextcloud/fix/noid/display-message-on-no-migration-attributes

fix(migration-preview): display a message if no attributes set

Author: ArtificialOwl

core/Command/Db/Migrations/PreviewCommand.php

@@ -62,6 +62,12 @@ public function execute(InputInterface $input, OutputInterface $output): int {
 		}
 		$table->render();
 
+		$unsupportedApps = $this->metadataManager->getUnsupportedApps($metadata['migrations']);
+		if (!empty($unsupportedApps)) {
+			$output->writeln('');
+			$output->writeln('Those apps are not supporting metadata yet and might initiate migrations on upgrade: <info>' . implode(', ', $unsupportedApps) . '</info>');
+		}
+
 		return 0;
 	}
 
@@ -90,6 +96,9 @@ private function displayMigrations(Table $table, string $appId, array $data): vo
 		/** @var MigrationAttribute[] $attributes */
 		foreach($data as $migration => $attributes) {
 			$attributesStr = [];
+			if (empty($attributes)) {
+				$attributesStr[] = '<comment>(metadata not set)</comment>';
+			}
 			foreach($attributes as $attribute) {
 				$definition = '<info>' . $attribute->definition() . "</info>";
 				$definition .= empty($attribute->getDescription()) ? '' : "\n  " . $attribute->getDescription();

lib/private/Migration/MetadataManager.php

@@ -88,6 +88,18 @@ public function getMigrationsAttributesFromReleaseMetadata(
 		];
 	}
 
+	/**
+	 * returns list of installed apps that does not support migrations metadata (yet)
+	 *
+	 * @param array<array-key, array<array-key, array>> $metadata
+	 *
+	 * @return string[]
+	 * @since 30.0.0
+	 */
+	public function getUnsupportedApps(array $metadata): array {
+		return array_values(array_diff($this->appManager->getInstalledApps(), array_keys($metadata['apps'])));
+	}
+
 	/**
 	 * convert raw data to a list of MigrationAttribute
 	 *