Merge pull request #25236 from nextcloud/mkdir-explicit-chmod

juliusknorr · web-flow · commit 349b65eff3ac · 2021-01-21T07:56:10.000+01:00
explicitly set permissions on newly created folders
diff --git a/lib/private/Files/Storage/Local.php b/lib/private/Files/Storage/Local.php
@@ -86,7 +86,10 @@ public function getId() {
 	}
 
 	public function mkdir($path) {
-		return @mkdir($this->getSourcePath($path), 0777, true);
+		$sourcePath = $this->getSourcePath($path);
+		$result = @mkdir($sourcePath, 0777, true);
+		chmod($sourcePath, 0755);
+		return $result;
 	}
 
 	public function rmdir($path) {

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,10 @@ public function getId() {`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`public function mkdir($path) {`
`89`		`- return @mkdir($this->getSourcePath($path), 0777, true);`
	`89`	`+ $sourcePath = $this->getSourcePath($path);`
	`90`	`+ $result = @mkdir($sourcePath, 0777, true);`
	`91`	`+ chmod($sourcePath, 0755);`
	`92`	`+ return $result;`
`90`	`93`	`}`
`91`	`94`
`92`	`95`	`public function rmdir($path) {`