Fix oracle LISTAGG

nickvergessen · vitormattos · commit 0c61aae9eb43 · 2022-01-03T21:35:44.000-03:00
Signed-off-by: Joas Schilling &lt;coding@schilljs.com&gt;
diff --git a/lib/private/DB/QueryBuilder/FunctionBuilder/OCIFunctionBuilder.php b/lib/private/DB/QueryBuilder/FunctionBuilder/OCIFunctionBuilder.php
@@ -76,7 +76,7 @@ public function least($x, $y): IQueryFunction {
 	public function groupConcat($expr, ?string $separator = ','): IQueryFunction {
 		$orderByClause = ' WITHIN GROUP(ORDER BY NULL)';
 		if (is_null($separator)) {
-			return new QueryFunction('LISTAGG(' . $this->helper->quoteColumnName($expr) . $orderByClause . ')');
+			return new QueryFunction('LISTAGG(' . $this->helper->quoteColumnName($expr) . ')' . $orderByClause);
 		}
 		return new QueryFunction('LISTAGG(' . $this->helper->quoteColumnName($expr) . ", '$separator')$orderByClause");
 	}

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ public function least($x, $y): IQueryFunction {`
`76`	`76`	`public function groupConcat($expr, ?string $separator = ','): IQueryFunction {`
`77`	`77`	`$orderByClause = ' WITHIN GROUP(ORDER BY NULL)';`
`78`	`78`	`if (is_null($separator)) {`
`79`		`- return new QueryFunction('LISTAGG(' . $this->helper->quoteColumnName($expr) . $orderByClause . ')');`
	`79`	`+ return new QueryFunction('LISTAGG(' . $this->helper->quoteColumnName($expr) . ')' . $orderByClause);`
`80`	`80`	`}`
`81`	`81`	`return new QueryFunction('LISTAGG(' . $this->helper->quoteColumnName($expr) . ", '$separator')$orderByClause");`
`82`	`82`	`}`