Use only one DetailsView instance across all filelist types

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Author: juliusknorr

apps/files/js/app.js

@@ -40,6 +40,13 @@
 		 */
 		fileList: null,
 
+		/**
+		 * File details view
+		 *
+		 * @member {OCA.Files.DetailsView}
+		 */
+		detailsView: null,
+
 		/**
 		 * Backbone model for storing files preferences
 		 */

apps/files/js/filelist.js

@@ -272,18 +272,21 @@
 				this.$el.toggleClass('hide-hidden-files', !this._filesConfig.get('showhidden'));
 			}
 
+			this._initFileActions(options.fileActions);
 
 			if (_.isUndefined(options.detailsViewEnabled) || options.detailsViewEnabled) {
-				this._detailsView = new OCA.Files.DetailsView();
+				if (OCA.Files.App.detailsView === null) {
+					OCA.Files.App.detailsView = new OCA.Files.DetailsView();
+					OCA.Files.App.detailsView.initialize();
+
+					this._detailsView = OCA.Files.App.detailsView;
+					this._detailsView.addDetailView(new OCA.Files.MainFileInfoDetailView({fileList: this, fileActions: this.fileActions}));
+				}
+				this._detailsView = OCA.Files.App.detailsView;
 				this._detailsView.$el.addClass('disappear');
 			}
-
 			this._initFileActions(options.fileActions);
 
-			if (this._detailsView) {
-				this._detailsView.addDetailView(new OCA.Files.MainFileInfoDetailView({fileList: this, fileActions: this.fileActions}));
-			}
-
 			this.files = [];
 			this._selectedFiles = {};
 			this._selectionSummary = new OCA.Files.FileSummary(undefined, {config: this._filesConfig});
@@ -374,7 +377,6 @@
 				}
 			}
 
-
 			OC.Plugins.attach('OCA.Files.FileList', this);
 		},
 
@@ -388,9 +390,7 @@
 			if (this._newButton) {
 				this._newButton.remove();
 			}
-			if (this._detailsView) {
-				this._detailsView.remove();
-			}
+
 			// TODO: also unregister other event handlers
 			this.fileActions.off('registerAction', this._onFileActionsUpdated);
 			this.fileActions.off('setDefault', this._onFileActionsUpdated);
@@ -3327,7 +3327,7 @@
 		 * Register a tab view to be added to all views
 		 */
 		registerTabView: function(tabView) {
-			if (this._detailsView) {
+			if (this._detailsView && (OCA.Files.App.fileList === null || OCA.Files.App.fileList === this)) {
 				this._detailsView.addTabView(tabView);
 			}
 		},
@@ -3336,7 +3336,7 @@
 		 * Register a detail view to be added to all views
 		 */
 		registerDetailView: function(detailView) {
-			if (this._detailsView) {
+			if (this._detailsView && (OCA.Files.App.fileList === null || OCA.Files.App.fileList === this)) {
 				this._detailsView.addDetailView(detailView);
 			}
 		},