Merge pull request #565 from nextcloud/backport/563/stable32

[stable32] fix(crawler): Skip notifications code completely in first run

Author: nickvergessen

appinfo/info.xml

@@ -9,7 +9,7 @@
 	<name>Nextcloud announcements</name>
 	<summary>Nextcloud announcements brings the latest news of Nextcloud into your notifications</summary>
 	<description>Nextcloud announcements brings the latest news of Nextcloud into your notifications</description>
-	<version>4.0.0-dev.0</version>
+	<version>4.0.0</version>
 	<licence>agpl</licence>
 	<author>Joas Schilling</author>
 	<namespace>NextcloudAnnouncements</namespace>

lib/Cron/Crawler.php

@@ -69,7 +69,7 @@ protected function run(mixed $argument): void {
 		$rssPubDate = (string)$rss->channel->pubDate;
 
 		$lastPubDate = $this->config->getAppValue($this->appName, 'pub_date', 'now');
-		if ($lastPubDate === 'now1') {
+		if ($lastPubDate === 'now') {
 			// First call, don't spam the user with old stuff...
 			$this->config->setAppValue($this->appName, 'pub_date', $rssPubDate);
 			return;
@@ -105,7 +105,7 @@ protected function run(mixed $argument): void {
 				$this->notificationManager->notify($notification);
 			}
 
-			$this->config->getAppValue($this->appName, $id, 'published');
+			$this->config->setAppValue($this->appName, $id, 'published');
 		}
 
 		$this->config->setAppValue($this->appName, 'pub_date', $rssPubDate);

tests/psalm-baseline.xml

@@ -1,21 +1,15 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="6.1.0@827971f8bc7a28bb4f842f34bf8901521de1cea3">
+<files psalm-version="6.14.3@d0b040a91f280f071c1abcb1b77ce3822058725a">
   <file src="lib/Cron/Crawler.php">
     <DeprecatedMethod>
       <code><![CDATA[getAppValue]]></code>
       <code><![CDATA[getAppValue]]></code>
       <code><![CDATA[getAppValue]]></code>
       <code><![CDATA[getAppValue]]></code>
-      <code><![CDATA[getAppValue]]></code>
+      <code><![CDATA[setAppValue]]></code>
       <code><![CDATA[setAppValue]]></code>
       <code><![CDATA[setAppValue]]></code>
     </DeprecatedMethod>
-    <InvalidReturnStatement>
-      <code><![CDATA[$response->getBody()]]></code>
-    </InvalidReturnStatement>
-    <InvalidReturnType>
-      <code><![CDATA[string]]></code>
-    </InvalidReturnType>
     <PossiblyFalseArgument>
       <code><![CDATA[$certificate]]></code>
       <code><![CDATA[$certificate]]></code>