Allow value of type array for NcActionInput - #3804
Merged
Merged
Conversation
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
added
bug
raimund-schluessler
requested review from
ChristophWurst,
Pytal,
marcoambrosini,
mejo-,
nickvergessen and
susnux
February 21, 2023 21:09
raimund-schluessler
marked this pull request as ready for review
February 21, 2023 21:11
nickvergessen
approved these changes
Feb 21, 2023
raimund-schluessler
enabled auto-merge
February 21, 2023 22:38
Pytal
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the
NcActionInputtype multiselect, we need to allow thevalueof typearrayin case on passes an object as the options. Otherwise we will get an invalid prop type check.Follow-up of #3760.