Fix prop type check for NcPopover setReturnFocus - #3803
Merged
Conversation
raimund-schluessler
requested review from
GretaD,
Pytal,
marcoambrosini,
mejo-,
skjnldsv,
susnux and
tacruc
February 21, 2023 08:14
raimund-schluessler
added
bug
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix/3801/actions-return-focus-type
branch
from
February 21, 2023 08:18
19ac3eb to
7ebbaa5
Compare
raimund-schluessler
marked this pull request as ready for review
February 21, 2023 08:20
Antreesy
approved these changes
Feb 21, 2023
Antreesy
left a comment
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
Should work properly, according to docs. Would be nice to see it in release ASAP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the invalid prop type check for
NcPopoversetReturnFocus. As per the focus-trap docs, allowed values areHTMLElement | SVGElement | string | Boolean, seehttps://github.com/focus-trap/focus-trap/blob/4cbbef5e971bcdadcc07c3cbb08d0fccfc001809/index.d.ts#L4-L5
Fixes #3801.