Also set Modal height/width to allow children to define their height/width and not only max-height/width - #1518
Merged
Merged
Conversation
…width and not only max-height/width Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
added
3. to review
skjnldsv
requested review from
ChristophWurst,
GretaD,
PVince81,
julien-nc,
juliusknorr,
marcoambrosini and
raimund-schluessler
October 26, 2020 10:39
julien-nc
reviewed
Oct 26, 2020
julien-nc
left a comment
julien-nc
left a comment
Contributor
There was a problem hiding this comment.
Looks fine.
Corners are rounded before and not after. Is it expected?
Contributor
Author
Yes, haven't applied the rounded corners on the proper element. This is unrelated to this component, :) |
GretaD
approved these changes
Oct 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For viewer, to automatically contain the image, we need a specific css pattern that rely on a combination of max and height/width.
If only one is defined the chaining is broken.