refactor(UserBackend): Port away from deprecated stuff

All of it is available since NC 28

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>

Author: CarlSchwan

lib/UserBackend.php

@@ -11,6 +11,7 @@
 use OCP\DB\QueryBuilder\IQueryBuilder;
 use OCP\EventDispatcher\GenericEvent;
 use OCP\EventDispatcher\IEventDispatcher;
+use OCP\Files\IRootFolder;
 use OCP\Files\NotPermittedException;
 use OCP\IDBConnection;
 use OCP\IGroupManager;
@@ -19,6 +20,7 @@
 use OCP\IUserBackend;
 use OCP\IUserManager;
 use OCP\User\Backend\ICountUsersBackend;
+use OCP\User\Events\UserFirstTimeLoggedInEvent;
 use OCP\UserInterface;
 
 class UserBackend implements IUserBackend, UserInterface, ICountUsersBackend {
@@ -33,6 +35,7 @@ public function __construct(
 		private IEventDispatcher $eventDispatcher,
 		private IGroupManager $groupManager,
 		private IUserManager $userManager,
+		private IRootFolder $rootFolder,
 	) {
 	}
 
@@ -66,7 +69,7 @@ public function implementsActions($actions): bool {
 	}
 
 	/**
-	 * Creates an user if it does not exists
+	 * Creates a user if it does not exist.
 	 *
 	 * @param string $uid
 	 */
@@ -76,17 +79,16 @@ public function createUserIfNotExists(string $uid): void {
 				'uid' => $uid,
 			];
 
-			/* @var $qb IQueryBuilder */
 			$qb = $this->db->getQueryBuilder();
 			$qb->insert($this->dbName);
 			foreach ($values as $column => $value) {
 				$qb->setValue($column, $qb->createNamedParameter($value));
 			}
-			$qb->execute();
+			$qb->executeStatement();
 
 			### Code taken from lib/private/User/Session.php - function prepareUserLogin() ###
 			//trigger creation of user home and /files folder
-			$userFolder = \OC::$server->getUserFolder($uid);
+			$userFolder = $this->rootFolder->getUserFolder($uid);
 			try {
 				// copy skeleton
 				\OC_Util::copySkeleton($uid, $userFolder);
@@ -96,6 +98,7 @@ public function createUserIfNotExists(string $uid): void {
 			// trigger any other initialization
 			$user = $this->userManager->get($uid);
 			$this->eventDispatcher->dispatch(IUser::class . '::firstLogin', new GenericEvent($user));
+			$this->eventDispatcher->dispatchTyped(new UserFirstTimeLoggedInEvent($user));
 		}
 	}
 
@@ -113,7 +116,7 @@ public function deleteUser($uid): bool {
 			$qb = $this->db->getQueryBuilder();
 			$qb->delete($this->dbName)
 				->where($qb->expr()->eq('uid', $qb->createNamedParameter($uid)))
-				->execute();
+				->executeStatement();
 
 			return true;
 		}
@@ -147,7 +150,7 @@ public function getUsers($search = '', $limit = null, $offset = null): array {
 		if ($offset !== null) {
 			$qb->setFirstResult($offset);
 		}
-		$result = $qb->execute();
+		$result = $qb->executeQuery();
 		$users = $result->fetchAll();
 		$result->closeCursor();
 
@@ -169,7 +172,7 @@ public function countUsers(): int {
 		$query = $this->db->getQueryBuilder();
 		$query->select($query->func()->count('uid'))
 			->from($this->dbName);
-		$result = $query->execute();
+		$result = $query->executeQuery();
 
 		return $result->fetchColumn();
 	}
@@ -200,7 +203,7 @@ public function setDisplayName(string $uid, string $displayName): bool {
 			$qb->update($this->dbName)
 				->set('displayname', $qb->createNamedParameter($displayName))
 				->where($qb->expr()->eq('uid', $qb->createNamedParameter($uid)))
-				->execute();
+				->executeStatement();
 
 			return true;
 		}
@@ -226,7 +229,7 @@ public function getDisplayName($uid): string {
 					->from($this->dbName)
 					->where($qb->expr()->eq('uid', $qb->createNamedParameter($uid)))
 					->setMaxResults(1);
-				$result = $qb->execute();
+				$result = $qb->executeQuery();
 				$users = $result->fetchAll();
 				if (isset($users[0]['displayname'])) {
 					return $users[0]['displayname'];
@@ -269,7 +272,7 @@ public function getDisplayNames($search = '', $limit = null, $offset = null): ar
 		if ($offset !== null) {
 			$qb->setFirstResult($offset);
 		}
-		$result = $qb->execute();
+		$result = $qb->executeQuery();
 		$users = $result->fetchAll();
 		$result->closeCursor();
 
@@ -446,7 +449,7 @@ protected function userExistsInDatabase(string $uid): bool {
 			->from($this->dbName)
 			->where($qb->expr()->eq('uid', $qb->createNamedParameter($uid)))
 			->setMaxResults(1);
-		$result = $qb->execute();
+		$result = $qb->executeQuery();
 		$users = $result->fetchAll();
 		$result->closeCursor();
 

tests/stub.phpstub

@@ -133,3 +133,35 @@ namespace OC\BackgroundJob {
 		}
 	}
 }
+
+namespace OC\Hooks {
+
+	/**
+	 * Class Emitter
+	 *
+	 * interface for all classes that are able to emit events
+	 *
+	 * @package OC\Hooks
+	 * @deprecated 18.0.0 use events and the \OCP\EventDispatcher\IEventDispatcher service
+	 */
+	interface Emitter {
+		/**
+		 * @param string $scope
+		 * @param string $method
+		 * @param callable $callback
+		 * @return void
+		 * @deprecated 18.0.0 use \OCP\EventDispatcher\IEventDispatcher::addListener
+		 */
+		public function listen($scope, $method, callable $callback) {
+		}
+
+		/**
+		 * @param string $scope optional
+		 * @param string $method optional
+		 * @param callable $callback optional
+		 * @return void
+		 * @deprecated 18.0.0 use \OCP\EventDispatcher\IEventDispatcher::removeListener
+		 */
+		public function removeListener($scope = null, $method = null, ?callable $callback = null) {
+		}
+}