Skip to content

Commit 6828732

Browse files
susnuxbackportbot[bot]
authored andcommitted
feat(NcSelect): add keepOpen property to replace closeOnSelect with default value true
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
1 parent 0a2de64 commit 6828732

1 file changed

Lines changed: 17 additions & 5 deletions

File tree

src/components/NcSelect/NcSelect.vue

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ const selectArray = [
6868
{
6969
props: {
7070
inputLabel: 'Multiple (objects, pre-selected, stay open on select)',
71+
keepOpen: true,
7172
multiple: true,
72-
closeOnSelect: false,
7373
options: [
7474
{
7575
id: 'foo',
@@ -234,7 +234,7 @@ const data1 = {
234234
props: {
235235
inputLabel: 'Wrapped (Default)',
236236
multiple: true,
237-
closeOnSelect: false,
237+
keepOpen: true,
238238
options: [
239239
'foo',
240240
'bar',
@@ -265,8 +265,8 @@ const data1 = {
265265
const data2 = {
266266
props: {
267267
inputLabel: 'Not wrapped',
268+
keepOpen: true,
268269
multiple: true,
269-
closeOnSelect: false,
270270
options: [
271271
'foo',
272272
'bar',
@@ -667,15 +667,26 @@ export default {
667667
},
668668
669669
/**
670-
* Close the dropdown when selecting an option
670+
* Close the dropdown when selecting an option.
671671
*
672-
* @see https://vue-select.org/api/props.html#closeonselect
672+
* @deprecated Use the `keepOpen` prop instead
673673
*/
674674
closeOnSelect: {
675675
type: Boolean,
676676
default: true,
677677
},
678678
679+
/**
680+
* Keep the dropdown open after selecting an option.
681+
*
682+
* @default false
683+
* @since 8.25.0
684+
*/
685+
keepOpen: {
686+
type: Boolean,
687+
default: false,
688+
},
689+
679690
/**
680691
* Replace default vue-select components
681692
*
@@ -1122,6 +1133,7 @@ export default {
11221133
// Custom overrides of vue-select props
11231134
value: this.model,
11241135
calculatePosition: this.localCalculatePosition,
1136+
closeOnSelect: this.closeOnSelect && !this.keepOpen,
11251137
filterBy: this.localFilterBy,
11261138
label: this.localLabel,
11271139
}

0 commit comments

Comments
 (0)