ci: fix phpstan & code-style (#2681)

DjordyKoert · web-flow · commit af0249817904 · 2026-02-04T11:47:31.000+01:00
## Description ~Fixes CI currently failing on warnings coming from api-platform. Fixed in api-platform/core#7694 Fixes failing PHPStan & code-style ## What type of PR is this? (check all applicable) - [ ] Bug Fix - [ ] Feature - [ ] Refactor - [ ] Deprecation - [ ] Breaking Change - [ ] Documentation Update - [x] CI ## Checklist - [ ] I have made corresponding changes to the documentation (`docs/`)
diff --git a/config/routing/swaggerui.php b/config/routing/swaggerui.php
@@ -12,7 +12,7 @@
 use Symfony\Component\Routing\Loader\Configurator\RoutingConfigurator;
 use Symfony\Component\Routing\Loader\XmlFileLoader;
 
-return function (RoutingConfigurator $routes): void {
+return static function (RoutingConfigurator $routes): void {
     foreach (debug_backtrace(\DEBUG_BACKTRACE_PROVIDE_OBJECT) as $trace) {
         if (isset($trace['object']) && $trace['object'] instanceof XmlFileLoader && 'doImport' === $trace['function']) {
             if (__DIR__ === dirname(realpath($trace['args'][3]))) {
diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php
@@ -51,7 +51,7 @@ public function getConfigTreeBuilder(): TreeBuilder
                 ->end()
                 ->arrayNode('cache')
                     ->validate()
-                        ->ifTrue(function ($v) { return null !== $v['item_id'] && null === $v['pool']; })
+                        ->ifTrue(static function ($v) { return null !== $v['item_id'] && null === $v['pool']; })
                         ->thenInvalid('Can not set cache.item_id if cache.pool is null')
                     ->end()
                     ->children()
@@ -121,15 +121,15 @@ public function getConfigTreeBuilder(): TreeBuilder
                         ]
                     )
                     ->beforeNormalization()
-                        ->ifTrue(function ($v) {
+                        ->ifTrue(static function ($v) {
                             return 0 === \count($v) || isset($v['path_patterns']) || isset($v['host_patterns']) || isset($v['documentation']);
                         })
-                        ->then(function ($v): array {
+                        ->then(static function ($v): array {
                             return ['default' => $v];
                         })
                     ->end()
                     ->validate()
-                        ->ifTrue(function ($v) {
+                        ->ifTrue(static function ($v) {
                             return !isset($v['default']);
                         })
                         ->thenInvalid('You must specify a `default` area under `nelmio_api_doc.areas`.')
@@ -229,14 +229,14 @@ public function getConfigTreeBuilder(): TreeBuilder
                                     ->variableNode('groups')
                                         ->defaultValue(null)
                                         ->validate()
-                                            ->ifTrue(function ($v) { return null !== $v && !\is_array($v); })
+                                            ->ifTrue(static function ($v) { return null !== $v && !\is_array($v); })
                                             ->thenInvalid('Model groups must be either `null` or an array.')
                                         ->end()
                                     ->end()
                                     ->variableNode('options')
                                         ->defaultValue(null)
                                         ->validate()
-                                            ->ifTrue(function ($v) { return null !== $v && !\is_array($v); })
+                                            ->ifTrue(static function ($v) { return null !== $v && !\is_array($v); })
                                             ->thenInvalid('Model options must be either `null` or an array.')
                                         ->end()
                                     ->end()
diff --git a/src/DependencyInjection/NelmioApiDocExtension.php b/src/DependencyInjection/NelmioApiDocExtension.php
@@ -173,7 +173,7 @@ public function load(array $configs, ContainerBuilder $container): void
             ->addTag('container.service_locator')
             ->addArgument(array_combine(
                 array_keys($config['areas']),
-                array_map(function ($area) { return new Reference(\sprintf('nelmio_api_doc.generator.%s', $area)); }, array_keys($config['areas']))
+                array_map(static function ($area) { return new Reference(\sprintf('nelmio_api_doc.generator.%s', $area)); }, array_keys($config['areas']))
             ));
 
         if (true === $config['type_info']) {
@@ -294,7 +294,7 @@ public function load(array $configs, ContainerBuilder $container): void
      */
     private function findNameAliases(array $names, string $area): array
     {
-        $nameAliases = array_filter($names, function (array $aliasInfo) use ($area) {
+        $nameAliases = array_filter($names, static function (array $aliasInfo) use ($area) {
             return [] === $aliasInfo['areas'] || \in_array($area, $aliasInfo['areas'], true);
         });
 
diff --git a/src/Describer/ApiPlatformDescriber.php b/src/Describer/ApiPlatformDescriber.php
@@ -27,7 +27,7 @@ public function __construct(object $documentation, NormalizerInterface $normaliz
             throw new \InvalidArgumentException(\sprintf('Argument 2 passed to %s() must implement %s and support normalization of %s. The normalizer provided is an instance of %s.', __METHOD__, NormalizerInterface::class, DocumentationInterface::class, $normalizer::class));
         }
 
-        parent::__construct(function () use ($documentation, $normalizer) {
+        parent::__construct(static function () use ($documentation, $normalizer) {
             $documentation = (array) $normalizer->normalize(
                 $documentation,
                 null,
diff --git a/src/Model/ModelRegistry.php b/src/Model/ModelRegistry.php
@@ -287,9 +287,9 @@ private function typeToString(LegacyType|Type $type): string
         } elseif ($type->isCollection()) {
             if (null !== $collectionType = ($type->getCollectionValueTypes()[0] ?? null)) {
                 return $this->typeToString($collectionType).'[]';
-            } else {
-                return 'mixed[]';
             }
+
+            return 'mixed[]';
         }
 
         return $type->getBuiltinType();
diff --git a/src/ModelDescriber/JMSModelDescriber.php b/src/ModelDescriber/JMSModelDescriber.php
@@ -250,7 +250,7 @@ private function computeGroups(Context $context, ?array $type = null): ?array
         }
 
         $groupsExclusion = $context->getExclusionStrategy();
-        if (!($groupsExclusion instanceof GroupsExclusionStrategy)) {
+        if (!$groupsExclusion instanceof GroupsExclusionStrategy) {
             return null;
         }
 
diff --git a/src/OpenApiPhp/Util.php b/src/OpenApiPhp/Util.php
@@ -26,24 +26,24 @@
  * of swagger Annotation classes with the following convenience methods
  * to get or create the respective Annotation instances if not found
  *
- * @see \Nelmio\ApiDocBundle\OpenApiPhp\Util::getPath()
- * @see \Nelmio\ApiDocBundle\OpenApiPhp\Util::getSchema()
- * @see \Nelmio\ApiDocBundle\OpenApiPhp\Util::getProperty()
- * @see \Nelmio\ApiDocBundle\OpenApiPhp\Util::getOperation()
- * @see \Nelmio\ApiDocBundle\OpenApiPhp\Util::getOperationParameter()
+ * @see Util::getPath()
+ * @see Util::getSchema()
+ * @see Util::getProperty()
+ * @see Util::getOperation()
+ * @see Util::getOperationParameter()
  *
  * which in turn get or create the Annotation instances through the following more general methods
- * @see \Nelmio\ApiDocBundle\OpenApiPhp\Util::getChild()
- * @see \Nelmio\ApiDocBundle\OpenApiPhp\Util::getCollectionItem()
- * @see \Nelmio\ApiDocBundle\OpenApiPhp\Util::getIndexedCollectionItem()
+ * @see Util::getChild()
+ * @see Util::getCollectionItem()
+ * @see Util::getIndexedCollectionItem()
  *
  * which then searches for an existing Annotation through
- * @see \Nelmio\ApiDocBundle\OpenApiPhp\Util::searchCollectionItem()
- * @see \Nelmio\ApiDocBundle\OpenApiPhp\Util::searchIndexedCollectionItem()
+ * @see Util::searchCollectionItem()
+ * @see Util::searchIndexedCollectionItem()
  *
  * and if not found the Annotation creates it through
- * @see \Nelmio\ApiDocBundle\OpenApiPhp\Util::createCollectionItem()
- * @see \Nelmio\ApiDocBundle\OpenApiPhp\Util::createContext()
+ * @see Util::createCollectionItem()
+ * @see Util::createContext()
  *
  * The merge method @see \Nelmio\ApiDocBundle\OpenApiPhp\Util::merge() has the main purpose to be able
  * to merge properties from an deeply nested array of Annotation properties in the structure of a
@@ -617,7 +617,7 @@ private static function mergeProperty(OA\AbstractAnnotation $annotation, string
      */
     private static function getNestingIndexes(string $class): array
     {
-        return array_map(function ($property) {
+        return array_map(static function ($property) {
             return \is_array($property) ? $property[0] : $property;
         }, $class::$_nested);
     }
diff --git a/src/Render/Html/GetNelmioAsset.php b/src/Render/Html/GetNelmioAsset.php
@@ -46,9 +46,9 @@ public function __invoke(string $defaultAssetsMode, string $asset): string
             return $this->renderJavascript($resource, $isInline);
         } elseif ('css' === $extension) {
             return $this->renderCss($resource, $isInline);
-        } else {
-            return $resource;
         }
+
+        return $resource;
     }
 
     /**
@@ -61,9 +61,9 @@ private function getExtension(string $assetsMode, string $asset): array
             return ['js', $assetsMode];
         } elseif ('png' === $extension) {
             return ['png', AssetsMode::OFFLINE === $assetsMode ? AssetsMode::CDN : $assetsMode];
-        } else {
-            return ['css', $assetsMode];
         }
+
+        return ['css', $assetsMode];
     }
 
     /**
@@ -77,26 +77,26 @@ private function getResource(string $asset, string $mode): array
             return [file_get_contents($this->resourcesDir.'/'.$asset), true];
         } elseif (AssetsMode::CDN === $mode) {
             return [$this->cdnUrl.'/'.$asset, false];
-        } else {
-            return [$this->assetExtension->getAssetUrl(\sprintf('bundles/nelmioapidoc/%s', $asset)), false];
         }
+
+        return [$this->assetExtension->getAssetUrl(\sprintf('bundles/nelmioapidoc/%s', $asset)), false];
     }
 
     private function renderJavascript(string $script, bool $isInline): string
     {
         if ($isInline) {
             return \sprintf('<script>%s</script>', $script);
-        } else {
-            return \sprintf('<script src="%s"></script>', $script);
         }
+
+        return \sprintf('<script src="%s"></script>', $script);
     }
 
     private function renderCss(string $stylesheet, bool $isInline): string
     {
         if ($isInline) {
             return \sprintf('<style>%s</style>', $stylesheet);
-        } else {
-            return \sprintf('<link rel="stylesheet" href="%s">', $stylesheet);
         }
+
+        return \sprintf('<link rel="stylesheet" href="%s">', $stylesheet);
     }
 }
diff --git a/src/RouteDescriber/FosRestDescriber.php b/src/RouteDescriber/FosRestDescriber.php
@@ -135,7 +135,7 @@ private function getFormat(mixed $requirements): ?string
      */
     private function getEnum(mixed $requirements, \ReflectionMethod $reflectionMethod): ?array
     {
-        if (!($requirements instanceof Choice)) {
+        if (!$requirements instanceof Choice) {
             return null;
         }
 
diff --git a/src/RouteDescriber/RouteMetadataDescriber.php b/src/RouteDescriber/RouteMetadataDescriber.php
@@ -127,9 +127,8 @@ private function getPossibleEnumValues(string $reqPattern): array
                 if ('' === $part || 0 === preg_match(self::ALPHANUM_EXPANDED_REGEX, $part)) {
                     // we check a complex regex expression containing | - abort in that case
                     return [];
-                } else {
-                    $requirements[] = $part;
                 }
+                $requirements[] = $part;
             }
         }
 
diff --git a/src/Routing/FilteredRouteCollectionBuilder.php b/src/Routing/FilteredRouteCollectionBuilder.php
@@ -143,7 +143,7 @@ private function defaultRouteDisabled(Route $route): bool
             return false;
         }
 
-        $annotations = array_map(function (\ReflectionAttribute $attribute) {
+        $annotations = array_map(static function (\ReflectionAttribute $attribute) {
             return $attribute->newInstance();
         }, $method->getAttributes(AbstractAnnotation::class, \ReflectionAttribute::IS_INSTANCEOF));
 
diff --git a/src/TypeDescriber/ArrayDescriber.php b/src/TypeDescriber/ArrayDescriber.php
@@ -31,7 +31,7 @@ public function describe(Type $type, Schema $schema, array $context = []): void
         }
 
         $arrayTypes = array_map(
-            fn (Type $keyType): Type => Type::array($type->getCollectionValueType(), $keyType),
+            static fn (Type $keyType): Type => Type::array($type->getCollectionValueType(), $keyType),
             $type->getCollectionKeyType()->getTypes()
         );
 
diff --git a/src/TypeDescriber/GenericClassDescriber.php b/src/TypeDescriber/GenericClassDescriber.php
@@ -42,6 +42,7 @@ public function __construct()
 
     public function describe(Type $type, Schema $schema, array $context = []): void
     {
+        /** @var ObjectType $wrappedType */
         $wrappedType = $type->getWrappedType();
         $reflectionClass = new \ReflectionClass($wrappedType->getClassName());
 
diff --git a/src/TypeDescriber/UnionDescriber.php b/src/TypeDescriber/UnionDescriber.php
@@ -29,7 +29,7 @@ final class UnionDescriber implements TypeDescriberInterface, TypeDescriberAware
 
     public function describe(Type $type, Schema $schema, array $context = []): void
     {
-        $innerTypes = array_values(array_filter($type->getTypes(), function (Type $innerType) {
+        $innerTypes = array_values(array_filter($type->getTypes(), static function (Type $innerType) {
             return !$innerType->isIdentifiedBy(TypeIdentifier::NULL);
         }));
 
diff --git a/src/Util/LegacyTypeConverter.php b/src/Util/LegacyTypeConverter.php
@@ -85,12 +85,18 @@ public static function toLegacyType(Type $type): LegacyType
             }
 
             if ($type->getWrappedType()->isIdentifiedBy(TypeIdentifier::OBJECT)) {
+                if ($type->getWrappedType() instanceof Type\GenericType) {
+                    /** @var Type\ObjectType $wrappedType */
+                    $wrappedType = $type->getWrappedType()->getWrappedType();
+                } else {
+                    /** @var Type\ObjectType $wrappedType */
+                    $wrappedType = $type->getWrappedType();
+                }
+
                 return new LegacyType(
                     LegacyType::BUILTIN_TYPE_OBJECT,
                     $nullable,
-                    $type->getWrappedType() instanceof Type\GenericType
-                        ? $type->getWrappedType()->getWrappedType()->getClassName()
-                        : $type->getWrappedType()->getClassName(),
+                    $wrappedType->getClassName(),
                     true,
                     collectionKeyType: $collectionKeyType,
                     collectionValueType: self::toLegacyType($type->getCollectionValueType()),
diff --git a/tests/Functional/ControllerTest.php b/tests/Functional/ControllerTest.php
@@ -55,7 +55,7 @@ public function testControllers(?string $controller, ?string $fixtureSuffix = nu
     {
         $fixtureName = null !== $fixtureSuffix ? $controller.'.'.$fixtureSuffix : $controller;
 
-        $routingConfiguration = function (RoutingConfigurator &$routes) use ($controller, $extraRoutes) {
+        $routingConfiguration = static function (RoutingConfigurator &$routes) use ($controller, $extraRoutes) {
             if (null !== $extraRoutes) {
                 ($extraRoutes)($routes);
             }
@@ -589,7 +589,7 @@ class_exists(LegacyType::class) ? 'cleanup-components' : 'cleanup-components-typ
                 ],
             ],
             [],
-            function (RoutingConfigurator $routes) {
+            static function (RoutingConfigurator $routes) {
                 $routes->add('security-manually-registered', '/security-manually-registered')
                     ->controller([SecuredApiController::class, 'fetchArticleAction'])
                     ->methods(['GET']);
@@ -630,7 +630,7 @@ function (RoutingConfigurator $routes) {
                 'web_custom_controller' => (new Definition(SecuredApiController::class))
                 ->setPublic(true),
             ],
-            function (RoutingConfigurator $routes) {
+            static function (RoutingConfigurator $routes) {
                 $routes->add('route_name', '/')
                     ->controller('web_custom_controller::fetchArticleAction')
                     ->methods(['GET']);
@@ -659,7 +659,7 @@ function (RoutingConfigurator $routes) {
                 'web_custom_controller' => (new Definition(SecuredApiController::class))
                     ->setPublic(true),
             ],
-            function (RoutingConfigurator $routes) {
+            static function (RoutingConfigurator $routes) {
                 $routes->add('route_name', '/')
                     ->controller('web_custom_controller::fetchArticleAction')
                     ->methods(['GET']);
diff --git a/tests/Functional/WebTestCase.php b/tests/Functional/WebTestCase.php
@@ -83,7 +83,7 @@ protected function getProperty(OA\Schema $annotation, string $property): OA\Prop
     protected function getParameter(OA\Operation|OA\OpenApi $annotation, string $name, string $in): OA\Parameter
     {
         $this->assertHasParameter($name, $in, $annotation);
-        $parameters = array_filter($annotation->parameters ?? [], function (OA\Parameter $parameter) use ($name, $in) {
+        $parameters = array_filter($annotation->parameters ?? [], static function (OA\Parameter $parameter) use ($name, $in) {
             return $parameter->name === $name && $parameter->in === $in;
         });
 
@@ -136,7 +136,7 @@ public function assertHasResponse($responseCode, OA\Operation $operation): void
      */
     public function assertHasParameter(string $name, string $in, OA\AbstractAnnotation $annotation): void
     {
-        $parameters = array_filter(Generator::UNDEFINED !== $annotation->parameters ? $annotation->parameters : [], function (OA\Parameter $parameter) use ($name, $in) {
+        $parameters = array_filter(Generator::UNDEFINED !== $annotation->parameters ? $annotation->parameters : [], static function (OA\Parameter $parameter) use ($name, $in) {
             return $parameter->name === $name && $parameter->in === $in;
         });
 
diff --git a/tests/ModelDescriber/FormModelDescriberTest.php b/tests/ModelDescriber/FormModelDescriberTest.php
@@ -33,7 +33,7 @@ public function testDescribeCreatesTokenPropertyDependingOnOptions(bool $csrfPro
         $formConfigMock = $this->createMock(FormConfigInterface::class);
         $formConfigMock->expects(self::exactly($csrfProtectionEnabled ? 2 : 1))
             ->method('getOption')
-            ->willReturnCallback(function (string $option, $default) use ($csrfProtectionEnabled, $tokenName) {
+            ->willReturnCallback(static function (string $option, $default) use ($csrfProtectionEnabled, $tokenName) {
                 if ('csrf_protection' === $option) {
                     return $csrfProtectionEnabled;
                 }
@@ -66,7 +66,7 @@ public function testDescribeCreatesTokenPropertyDependingOnOptions(bool $csrfPro
         $describer->describe($model, $schema);
 
         if ($expectProperty) {
-            $filteredProperties = array_filter($schema->properties, function (Property $property) use ($tokenName) {
+            $filteredProperties = array_filter($schema->properties, static function (Property $property) use ($tokenName) {
                 return $property->property === $tokenName;
             });
 
diff --git a/tests/SwaggerPhp/UtilTest.php b/tests/SwaggerPhp/UtilTest.php
@@ -114,7 +114,7 @@ public function testCreateChildWithEmptyProperties(): void
         /** @var OA\Info $info */
         $info = Util::createChild($this->rootAnnotation, OA\Info::class, $properties);
 
-        $properties = array_filter(get_object_vars($info), function ($key) {
+        $properties = array_filter(get_object_vars($info), static function ($key) {
             return !str_starts_with($key, '_');
         }, \ARRAY_FILTER_USE_KEY);
 
@@ -947,7 +947,7 @@ public function assertContextIsConnectedToRootContext(Context $context): void
      */
     private function getSetupPropertiesWithoutClass(array $setup): array
     {
-        return array_filter($setup, function ($k) {return 'class' !== $k; }, \ARRAY_FILTER_USE_KEY);
+        return array_filter($setup, static function ($k) {return 'class' !== $k; }, \ARRAY_FILTER_USE_KEY);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public function __construct(object $documentation, NormalizerInterface $normaliz`
`27`	`27`	`throw new \InvalidArgumentException(\sprintf('Argument 2 passed to %s() must implement %s and support normalization of %s. The normalizer provided is an instance of %s.', __METHOD__, NormalizerInterface::class, DocumentationInterface::class, $normalizer::class));`
`28`	`28`	`}`
`29`	`29`
`30`		`- parent::__construct(function () use ($documentation, $normalizer) {`
	`30`	`+ parent::__construct(static function () use ($documentation, $normalizer) {`
`31`	`31`	`$documentation = (array) $normalizer->normalize(`
`32`	`32`	`$documentation,`
`33`	`33`	`null,`
Original file line number	Diff line number	Diff line change
`@@ -287,9 +287,9 @@ private function typeToString(LegacyType\|Type $type): string`
`287`	`287`	`} elseif ($type->isCollection()) {`
`288`	`288`	`if (null !== $collectionType = ($type->getCollectionValueTypes()[0] ?? null)) {`
`289`	`289`	`return $this->typeToString($collectionType).'[]';`
`290`		`- } else {`
`291`		`- return 'mixed[]';`
`292`	`290`	`}`
	`291`	`+`
	`292`	`+ return 'mixed[]';`
`293`	`293`	`}`
`294`	`294`
`295`	`295`	`return $type->getBuiltinType();`
Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ private function computeGroups(Context $context, ?array $type = null): ?array`
`250`	`250`	`}`
`251`	`251`
`252`	`252`	`$groupsExclusion = $context->getExclusionStrategy();`
`253`		`- if (!($groupsExclusion instanceof GroupsExclusionStrategy)) {`
	`253`	`+ if (!$groupsExclusion instanceof GroupsExclusionStrategy) {`
`254`	`254`	`return null;`
`255`	`255`	`}`
`256`	`256`
Original file line number	Diff line number	Diff line change
`@@ -46,9 +46,9 @@ public function __invoke(string $defaultAssetsMode, string $asset): string`
`46`	`46`	`return $this->renderJavascript($resource, $isInline);`
`47`	`47`	`} elseif ('css' === $extension) {`
`48`	`48`	`return $this->renderCss($resource, $isInline);`
`49`		`- } else {`
`50`		`- return $resource;`
`51`	`49`	`}`
	`50`	`+`
	`51`	`+ return $resource;`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`/**`
`@@ -61,9 +61,9 @@ private function getExtension(string $assetsMode, string $asset): array`
`61`	`61`	`return ['js', $assetsMode];`
`62`	`62`	`} elseif ('png' === $extension) {`
`63`	`63`	`return ['png', AssetsMode::OFFLINE === $assetsMode ? AssetsMode::CDN : $assetsMode];`
`64`		`- } else {`
`65`		`- return ['css', $assetsMode];`
`66`	`64`	`}`
	`65`	`+`
	`66`	`+ return ['css', $assetsMode];`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`/**`
`@@ -77,26 +77,26 @@ private function getResource(string $asset, string $mode): array`
`77`	`77`	`return [file_get_contents($this->resourcesDir.'/'.$asset), true];`
`78`	`78`	`} elseif (AssetsMode::CDN === $mode) {`
`79`	`79`	`return [$this->cdnUrl.'/'.$asset, false];`
`80`		`- } else {`
`81`		`- return [$this->assetExtension->getAssetUrl(\sprintf('bundles/nelmioapidoc/%s', $asset)), false];`
`82`	`80`	`}`
	`81`	`+`
	`82`	`+ return [$this->assetExtension->getAssetUrl(\sprintf('bundles/nelmioapidoc/%s', $asset)), false];`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`private function renderJavascript(string $script, bool $isInline): string`
`86`	`86`	`{`
`87`	`87`	`if ($isInline) {`
`88`	`88`	`return \sprintf('<script>%s</script>', $script);`
`89`		`- } else {`
`90`		`- return \sprintf('<script src="%s"></script>', $script);`
`91`	`89`	`}`
	`90`	`+`
	`91`	`+ return \sprintf('<script src="%s"></script>', $script);`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`private function renderCss(string $stylesheet, bool $isInline): string`
`95`	`95`	`{`
`96`	`96`	`if ($isInline) {`
`97`	`97`	`return \sprintf('<style>%s</style>', $stylesheet);`
`98`		`- } else {`
`99`		`- return \sprintf('<link rel="stylesheet" href="%s">', $stylesheet);`
`100`	`98`	`}`
	`99`	`+`
	`100`	`+ return \sprintf('<link rel="stylesheet" href="%s">', $stylesheet);`
`101`	`101`	`}`
`102`	`102`	`}`
Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ private function getFormat(mixed $requirements): ?string`
`135`	`135`	`*/`
`136`	`136`	`private function getEnum(mixed $requirements, \ReflectionMethod $reflectionMethod): ?array`
`137`	`137`	`{`
`138`		`- if (!($requirements instanceof Choice)) {`
	`138`	`+ if (!$requirements instanceof Choice) {`
`139`	`139`	`return null;`
`140`	`140`	`}`
`141`	`141`
Original file line number	Diff line number	Diff line change
`@@ -127,9 +127,8 @@ private function getPossibleEnumValues(string $reqPattern): array`
`127`	`127`	`if ('' === $part \|\| 0 === preg_match(self::ALPHANUM_EXPANDED_REGEX, $part)) {`
`128`	`128`	`// we check a complex regex expression containing \| - abort in that case`
`129`	`129`	`return [];`
`130`		`- } else {`
`131`		`- $requirements[] = $part;`
`132`	`130`	`}`
	`131`	`+ $requirements[] = $part;`
`133`	`132`	`}`
`134`	`133`	`}`
`135`	`134`