fix(SplObjectStorage): SplObjectStorage::detach() is deprecated since 8.5, use method SplObjectStorage::offsetUnset()`` instead (#2634)

DjordyKoert · web-flow · commit 94f6895bb440 · 2025-11-28T11:16:07.000+01:00
## Description

Fixes deprecation in PHP 8.5
&gt; `SplObjectStorage::detach()`` is deprecated since `8.5`, use method
`SplObjectStorage::offsetUnset()`` instead

## What type of PR is this? (check all applicable)
- [x] Bug Fix
- [ ] Feature
- [ ] Refactor
- [ ] Deprecation
- [ ] Breaking Change
- [ ] Documentation Update
- [ ] CI

## Checklist
- [ ] I have made corresponding changes to the documentation (`docs/`)
diff --git a/src/OpenApiPhp/ModelRegister.php b/src/OpenApiPhp/ModelRegister.php
@@ -132,7 +132,7 @@ private function detach(ModelAnnotation $model, OA\AbstractAnnotation $annotatio
             }
         }
 
-        $analysis->annotations->detach($model);
+        $analysis->annotations->offsetUnset($model);
     }
 
     private function getModel(OA\AbstractAnnotation $annotation): ?ModelAnnotation

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ private function detach(ModelAnnotation $model, OA\AbstractAnnotation $annotatio`
`132`	`132`	`}`
`133`	`133`	`}`
`134`	`134`
`135`		`- $analysis->annotations->detach($model);`
	`135`	`+ $analysis->annotations->offsetUnset($model);`
`136`	`136`	`}`
`137`	`137`
`138`	`138`	`private function getModel(OA\AbstractAnnotation $annotation): ?ModelAnnotation`