Lspci: only refresh the pciids database once per node

get_devices ran update-pciids on every forced refresh, which adds a
network download and a noticeable delay to hot plug tests that rescan
the pci bus repeatedly. Track whether the database was already updated
for this tool instance and skip the refresh afterwards.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5d5f58ad-b9df-4420-ad37-22caee78e925

Author: mcgov

lisa/tools/lspci.py

@@ -196,6 +196,7 @@ def can_install(self) -> bool:
     def _initialize(self, *args: Any, **kwargs: Any) -> None:
         self._command = "lspci"
         self._pci_devices: List[PciDevice] = []
+        self._pciids_initialized: bool = False
 
     def _install(self) -> bool:
         if isinstance(self.node.os, Posix):
@@ -293,10 +294,12 @@ def get_devices_by_type(
     @retry(KeyError, tries=30, delay=2)  # type: ignore
     def get_devices(self, force_run: bool = False) -> List[PciDevice]:
         if (not self._pci_devices) or force_run:
+            if not self._pciids_initialized:
+                # Ensure pci device ids and name mappings are updated.
+                self.node.execute("update-pciids", sudo=True, shell=True)
+                self._pciids_initialized = True
             self._pci_devices = []
             self._pci_ids = {}
-            # Ensure pci device ids and name mappings are updated.
-            self.node.execute("update-pciids", sudo=True, shell=True)
 
             # Fetching the id information using 'lspci -nnm' is not reliable
             # due to inconsistencies in device id patterns.