Remove try_as_with_reason and just call as

Author: dmachaj

cppwinrt/code_writers.h

@@ -1130,15 +1130,14 @@ namespace cppwinrt
             {
                 // we intentionally ignore errors when unregistering event handlers to be consistent with event_revoker
                 //
-                // The `noexcept` versions will crash if check_hresult throws but that is no different than previous
+                // The `noexcept` versions will crash if .as<>() throws but that is no different than previous
                 // behavior where it would not check the cast result and nullptr crash.  At least the exception will terminate
                 // immediately while preserving the error code and local variables.
                 format = R"(    template <typename D%> auto consume_%<D%>::%(%) const noexcept
     {%
         if constexpr (!std::is_same_v<D, %>)
         {
-            auto const& [castedResult, code] = static_cast<D const*>(this)->template try_as_with_reason<%>();
-            check_hresult(code);
+            auto const& castedResult = static_cast<D const*>(this)->template as<%>();
             auto const abiType = *(abi_t<%>**)&castedResult;
             abiType->%(%);
         }
@@ -1156,8 +1155,7 @@ namespace cppwinrt
     {%
         if constexpr (!std::is_same_v<D, %>)
         {
-            auto const& [castedResult, code] = static_cast<D const*>(this)->template try_as_with_reason<%>();
-            check_hresult(code);
+            auto const& castedResult = static_cast<D const*>(this)->template as<%>();
             auto const abiType = *(abi_t<%>**)&castedResult;
             WINRT_VERIFY_(0, abiType->%(%));
         }
@@ -1176,8 +1174,7 @@ namespace cppwinrt
     {%
         if constexpr (!std::is_same_v<D, %>)
         {
-            auto const& [castedResult, code] = static_cast<D const*>(this)->template try_as_with_reason<%>();
-            check_hresult(code);
+            auto const& castedResult = static_cast<D const*>(this)->template as<%>();
             auto const abiType = *(abi_t<%>**)&castedResult;
             check_hresult(abiType->%(%));
         }

strings/base_implements.h

@@ -783,15 +783,15 @@ namespace winrt::impl
     struct WINRT_IMPL_EMPTY_BASES root_implements_composing_outer<true>
     {
         template <typename Qi>
-        auto try_as() const noexcept
+        auto as() const noexcept
         {
-            return m_inner.try_as<Qi>();
+            return m_inner.as<Qi>();
         }
 
         template <typename Qi>
-        auto try_as_with_reason() const noexcept
+        auto try_as() const noexcept
         {
-            return m_inner.try_as_with_reason<Qi>();
+            return m_inner.try_as<Qi>();
         }
 
         explicit operator bool() const noexcept

strings/base_windows.h

@@ -131,23 +131,6 @@ namespace winrt::impl
         ptr->QueryInterface(guid_of<To>(), &result);
         return wrap_as_result<To>(result);
     }
-
-    template <typename To, typename From, std::enable_if_t<is_com_interface_v<To>, int> = 0>
-    std::pair<com_ref<To>, hresult> try_as_with_reason(From* ptr) noexcept
-    {
-#ifdef WINRT_DIAGNOSTICS
-        get_diagnostics_info().add_query<To>();
-#endif
-
-        if (!ptr)
-        {
-            return { nullptr, 0 };
-        }
-
-        void* result{};
-        hresult code = ptr->QueryInterface(guid_of<To>(), &result);
-        return { wrap_as_result<To>(result), code };
-    }
 }
 
 WINRT_EXPORT namespace winrt::Windows::Foundation
@@ -222,12 +205,6 @@ WINRT_EXPORT namespace winrt::Windows::Foundation
             return impl::try_as<To>(m_ptr);
         }
 
-        template <typename To>
-        auto try_as_with_reason() const noexcept
-        {
-            return impl::try_as_with_reason<To>(m_ptr);
-        }
-
         template <typename To>
         void as(To& to) const
         {