Default new E-Document services to import v2 and let users select the draft format (#9702)

## Why

New E-Document services should default to the **v2 import pipeline** and
let users actually configure it end-to-end. This needs two things that
belong together:

1. Making the **Import Process** selector visible on the service card
and defaulting new services to **Version 2.0**.
2. Letting the user pick the **format** v2 needs to read an incoming
structured document into a draft.

That format is the service-level `"Read into Draft Impl."` field (table
6103, field 33). For already-structured formats such as **PEPPOL XML**
the "Structure received data" step returns `Unspecified`, so
`ImportEDocumentProcess.ReadIntoDraft` falls back to this service field:

```al
if EDocument."Read into Draft Impl." = "E-Doc. Read into Draft"::Unspecified then
    EDocument."Read into Draft Impl." := EDocument.GetEDocumentService()."Read into Draft Impl.";
```

If the service field is also `Unspecified`, `E-Doc. Unspecified Impl.`
runs and import fails with **"No method to read the e-document has been
provided."** Defaulting to v2 without exposing this field would leave
users unable to make v2 work.

## What

- Default new services to `Import Process` = **Version 2.0**
(`InitValue`) and remove `Visible = false` on the selector.
- Pin the **ForNAV** connector service to Version 1.0 at creation (its
inbound is not migrated to v2).
- Add `"Read into Draft Impl."` to the **Purchase Draft** group on the
service card (shown only for Version 2.0), captioned **Draft Format**,
with a tooltip covering PEPPOL vs. auto-resolved PDF/ADI.
- Update module docs and add tests: new services default to v2, and the
draft format is selectable and persisted for v2.


[AB#580191](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/580191)

---------

Co-authored-by: Magnus Hartvig Grønbech <magnushar@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 57f500b9-871d-4cf4-bdc1-751bea22d091

Author: 3 people

src/Apps/W1/EDocument/App/CLAUDE.md

@@ -55,7 +55,7 @@ src/
 - The import pipeline implementation fields live directly on the E-Document table: `"Structure Data Impl."`, `"Read into Draft Impl."`, and `"Process Draft Impl."`. These enums determine which interface implementations run at each stage.
 - `"E-Document Service Status"` enum implements `IEDocumentStatus` interface -- each status value knows whether it means "in progress", "processed", or "error", via `EDocInProgressStatus`, `EDocProcessedStatus`, and `EDocErrorStatus` codeunits.
 - Batch processing and single-document processing are distinct code paths. Batch mode uses recurrent background jobs configured on the service (fields 21-26 on `"E-Document Service"`).
-- The V1.0 import process (`"Import Process" = "Version 1.0"`) collapses all pipeline stages into a single "Finish draft" step. V2.0 is the current architecture.
+- The V1.0 import process (`"Import Process" = "Version 1.0"`) collapses all pipeline stages into a single "Finish draft" step. V2.0 is the current architecture, and new services default to it. The import version is selectable on the service card. For V2.0 services the service-level `"Read into Draft Impl."` field ("Draft Format" on the card) selects how already-structured documents (e.g. PEPPOL XML) are read into a draft; it is the fallback used when neither the structuring step nor the receiving integration sets a reader, so leaving it `Unspecified` for such formats makes import fail.
 - `#if not CLEAN26` and `#if not CLEAN27` blocks mark deprecated code scheduled for removal. The old `"E-Document Integration"` enum and its `"Service Integration"` field on the service table are fully replaced by `"Service Integration V2"`.
 - The framework uses the "if codeunit.run" pattern extensively -- interface calls are wrapped in codeunits that run with error trapping, so a connector failure produces a logged error rather than a crash.
 - `"E-Document Background Jobs"` manages Job Queue Entries for recurrent import polling and batch send processing.

src/Apps/W1/EDocument/App/docs/business-logic.md

@@ -107,7 +107,8 @@ Beyond send and receive, the framework supports arbitrary actions on documents v
 - **Re-reading after interface calls**: After every interface call, the framework re-reads the E-Document and service records from the database (`EDocument.Get(EDocument."Entry No")`). This is because interface implementations may modify these records, and the framework needs the latest values. Note: this defensive re-read is most important when the interface parameter is **not** passed by `var`. The original intent of non-`var` parameters was to prevent implementations from modifying records through the parameter, but since AL code can always call `.Modify()` directly on any record, the protection is incomplete. When adding new interface methods, only apply this re-read pattern to procedures where the record is not passed by `var` -- if the signature already uses `var`, the caller expects modifications and re-reading is redundant.
 - **E-Document Status is derived**: The overall `E-Document Status` is derived from the service statuses. `EDocumentProcessing.ModifyEDocumentStatus()` computes it after every service status change using the `IEDocumentStatus` interface on the enum values.
 - **Import Processing Status is a FlowField**: On the E-Document table, `"Import Processing Status"` is a FlowField that reads from `"E-Document Service Status"`. You must call `CalcFields` before reading it.
-- **V1.0 and V2.0 coexistence**: The `"Import Process"` field on the service determines which path runs. V1.0 collapses everything into a single "Finish draft" step that calls the old `V1_ProcessEDocument` logic. The pipeline state machine still runs, but only the last step does anything for V1.0 documents.
+- **V1.0 and V2.0 coexistence**: The `"Import Process"` field on the service determines which path runs; new services default to Version 2.0, and the version is selectable on the service card. V1.0 collapses everything into a single "Finish draft" step that calls the old `V1_ProcessEDocument` logic. The pipeline state machine still runs, but only the last step does anything for V1.0 documents.
+- **Selecting the V2.0 draft format**: For Version 2.0 services the `"Read into Draft Impl."` field (shown as "Draft Format" on the service card) selects how the inbound structured e-document is read into a draft. For already-structured formats such as PEPPOL XML the structuring step returns `Unspecified`, so the read step falls back to the service's `"Read into Draft Impl."`; if that is also `Unspecified`, the `E-Doc. Unspecified Impl.` runs and import errors with "No method to read the e-document has been provided." PDF services (e.g. Azure Document Intelligence) resolve the reader automatically during structuring, so their format field can stay `Unspecified`.
 
 ## Inbound flow (V1.0 pipeline)
 

src/Apps/W1/EDocument/App/src/Service/EDocumentService.Table.al

@@ -269,6 +269,7 @@ table 6103 "E-Document Service"
         {
             Caption = 'Import Process';
             DataClassification = SystemMetadata;
+            InitValue = "Version 2.0";
             ToolTip = 'Specifies the import process for the document.';
         }
         field(32; "Automatic Import Processing"; Enum "E-Doc. Automatic Processing")

src/Apps/W1/EDocument/App/src/Service/EdocumentService.Page.al

@@ -72,12 +72,16 @@ page 6133 "E-Document Service"
                 field("Import Process"; Rec."Import Process")
                 {
                     ToolTip = 'Specifies the version of the import process to use for incoming e-documents.';
-                    Visible = false;
                 }
                 group(PurchaseDraft)
                 {
                     Caption = 'Purchase Draft';
                     Visible = Rec."Import Process" = Enum::"E-Document Import Process"::"Version 2.0";
+                    field("Read into Draft Impl."; Rec."Read into Draft Impl.")
+                    {
+                        Caption = 'Draft Format';
+                        ToolTip = 'Specifies the format used to read the incoming structured e-document into a draft, for example PEPPOL for PEPPOL BIS invoices. Leave it as Unspecified only when the integration or a PDF reader (such as Azure Document Intelligence) determines the format automatically.';
+                    }
                     field("Verify Totals When Posting"; Rec."Verify Purch. Total Amounts")
                     {
                         Caption = 'Verify totals when posting invoice.';

src/Apps/W1/EDocument/App/src/Service/docs/CLAUDE.md

@@ -8,7 +8,7 @@ A service is identified by a `Code[20]` primary key and configures two pluggable
 
 For outbound documents, the service controls batch processing via `Use Batch Processing`, `Batch Mode`, `Batch Threshold`, and scheduling fields (`Batch Start Time`, `Batch Minutes between runs`). Enabling batch processing automatically creates a recurrent job queue entry (tracked by `Batch Recurrent Job Id`). For inbound documents, `Auto Import` plus `Import Start Time` and `Import Minutes between runs` configure a separate recurrent job (tracked by `Import Recurrent Job Id`). Both job queue entries are cleaned up automatically when the service is deleted.
 
-The service also carries extensive inbound processing configuration: `Import Process` selects between Version 1.0 and 2.0 pipelines, `Automatic Import Processing` controls whether documents are fully processed on arrival or parked for manual review, and `Read into Draft Impl.` selects the strategy for converting structured content into draft purchase documents. A set of boolean flags (`Validate Receiving Company`, `Resolve Unit Of Measure`, `Lookup Item Reference`, `Lookup Item GTIN`, `Lookup Account Mapping`, `Validate Line Discount`, `Apply Invoice Discount`, `Verify Totals`, `Verify Purch. Total Amounts`) governs which validation and enrichment steps run during import.
+The service also carries extensive inbound processing configuration: `Import Process` selects between Version 1.0 and 2.0 pipelines (new services default to Version 2.0, and the version is selectable on the service card), `Automatic Import Processing` controls whether documents are fully processed on arrival or parked for manual review, and `Read into Draft Impl.` selects the strategy (the "Draft Format", e.g. PEPPOL) for converting structured content into draft purchase documents -- for Version 2.0 services this is exposed on the service card so users can pick the format their integration delivers. A set of boolean flags (`Validate Receiving Company`, `Resolve Unit Of Measure`, `Lookup Item Reference`, `Lookup Item GTIN`, `Lookup Account Mapping`, `Validate Line Discount`, `Apply Invoice Discount`, `Verify Totals`, `Verify Purch. Total Amounts`) governs which validation and enrichment steps run during import.
 
 The `E-Doc. Service Supported Type` table (`EDocServiceSupportedType.Table.al`, table 6122) bridges services to document types -- a service can handle any subset of the `E-Document Type` enum values. The `Service Participant` table (`Participant/ServiceParticipant.Table.al`, table 6104) links customers or vendors to specific services with per-participant identifiers used for electronic addressing (e.g., PEPPOL participant IDs).
 

src/Apps/W1/EDocument/Test/src/LibraryEDocument.Codeunit.al

@@ -799,6 +799,7 @@ codeunit 139629 "Library - E-Document"
         EDocService.Code := LibraryUtility.GenerateRandomCode20(EDocService.FieldNo(Code), Database::"E-Document Service");
         EDocService."Document Format" := "E-Document Format"::Mock;
         EDocService."Service Integration" := Integration;
+        EDocService."Import Process" := Enum::"E-Document Import Process"::"Version 1.0";
         EDocService.Insert();
 
         CreateSupportedDocTypes(EDocService);
@@ -816,6 +817,7 @@ codeunit 139629 "Library - E-Document"
         EDocService.Code := LibraryUtility.GenerateRandomCode20(EDocService.FieldNo(Code), Database::"E-Document Service");
         EDocService."Document Format" := "E-Document Format"::Mock;
         EDocService."Service Integration V2" := Integration;
+        EDocService."Import Process" := Enum::"E-Document Import Process"::"Version 1.0";
         EDocService.Insert();
 
         CreateSupportedDocTypes(EDocService);
@@ -834,6 +836,7 @@ codeunit 139629 "Library - E-Document"
         EDocService.Code := LibraryUtility.GenerateRandomCode20(EDocService.FieldNo(Code), Database::"E-Document Service");
         EDocService."Document Format" := EDocDocumentFormat;
         EDocService."Service Integration" := EDocIntegration;
+        EDocService."Import Process" := Enum::"E-Document Import Process"::"Version 1.0";
         EDocService.Insert();
 
         CreateSupportedDocTypes(EDocService);
@@ -969,6 +972,7 @@ codeunit 139629 "Library - E-Document"
             EDocService.Code := 'TESTRECEIVE';
             EDocService."Document Format" := "E-Document Format"::Mock;
             EDocService."Service Integration V2" := Integration;
+            EDocService."Import Process" := Enum::"E-Document Import Process"::"Version 1.0";
             EDocService.Insert();
         end;
     end;
@@ -983,6 +987,7 @@ codeunit 139629 "Library - E-Document"
             EDocService.Code := 'TESTRECEIVE';
             EDocService."Document Format" := "E-Document Format"::Mock;
             EDocService."Service Integration" := Integration;
+            EDocService."Import Process" := Enum::"E-Document Import Process"::"Version 1.0";
             EDocService.Insert();
         end;
     end;
@@ -996,6 +1001,7 @@ codeunit 139629 "Library - E-Document"
             EDocService.Code := 'BIERRRECEIVE';
             EDocService."Document Format" := "E-Document Format"::Mock;
             EDocService."Service Integration V2" := Integration;
+            EDocService."Import Process" := Enum::"E-Document Import Process"::"Version 1.0";
             EDocService.Insert();
         end;
     end;
@@ -1010,6 +1016,7 @@ codeunit 139629 "Library - E-Document"
             EDocService.Code := 'BIERRRECEIVE';
             EDocService."Document Format" := "E-Document Format"::Mock;
             EDocService."Service Integration" := Integration;
+            EDocService."Import Process" := Enum::"E-Document Import Process"::"Version 1.0";
             EDocService.Insert();
         end;
     end;
@@ -1023,6 +1030,7 @@ codeunit 139629 "Library - E-Document"
             EDocService.Code := 'CIERRRECEIVE';
             EDocService."Document Format" := "E-Document Format"::Mock;
             EDocService."Service Integration V2" := Integration;
+            EDocService."Import Process" := Enum::"E-Document Import Process"::"Version 1.0";
             EDocService.Insert();
         end;
     end;
@@ -1037,6 +1045,7 @@ codeunit 139629 "Library - E-Document"
             EDocService.Code := 'CIERRRECEIVE';
             EDocService."Document Format" := "E-Document Format"::Mock;
             EDocService."Service Integration" := Integration;
+            EDocService."Import Process" := Enum::"E-Document Import Process"::"Version 1.0";
             EDocService.Insert();
         end;
     end;

src/Apps/W1/EDocument/Test/src/Processing/EDocProcessTest.Codeunit.al

@@ -1443,4 +1443,49 @@ codeunit 139883 "E-Doc Process Test"
         ItemReference.Insert();
     end;
 
+    [Test]
+    procedure NewServiceDefaultsToImportProcessV2()
+    var
+        EDocumentService: Record "E-Document Service";
+    begin
+        // [WHEN] A new E-Document Service record is initialized
+        EDocumentService.Init();
+        // [THEN] Import Process defaults to Version 2.0
+        Assert.AreEqual(
+            EDocumentService."Import Process"::"Version 2.0", EDocumentService."Import Process",
+            'New services must default to the v2 draft pipeline.');
+    end;
+
+    [Test]
+    procedure DraftFormatSelectableForImportProcessV2()
+    var
+        EDocService: Record "E-Document Service";
+        EDocServicePage: TestPage "E-Document Service";
+    begin
+        // [FEATURE] [E-Document] [Import]
+        // [SCENARIO] The draft format ("Read into Draft Impl.") is selectable on the service card for Version 2.0 services
+        if EDocService.Get('V2DRAFTFMT') then
+            EDocService.Delete();
+
+        // [GIVEN] An E-Document Service using import process Version 2.0
+        EDocService.Init();
+        EDocService.Code := 'V2DRAFTFMT';
+        EDocService."Import Process" := EDocService."Import Process"::"Version 2.0";
+        EDocService.Insert();
+
+        // [WHEN] Opening the service card and selecting a draft format
+        EDocServicePage.OpenEdit();
+        EDocServicePage.GoToRecord(EDocService);
+        // [THEN] The draft format field is available so the user can tell v2 how to read the incoming document
+        Assert.IsTrue(EDocServicePage."Read into Draft Impl.".Editable(), 'Draft Format must be editable for Version 2.0 services.');
+        EDocServicePage."Read into Draft Impl.".SetValue(Enum::"E-Doc. Read into Draft"::PEPPOL);
+        EDocServicePage.Close();
+
+        // [THEN] The selected format is persisted on the service
+        EDocService.Find();
+        Assert.AreEqual(
+            Enum::"E-Doc. Read into Draft"::PEPPOL, EDocService."Read into Draft Impl.",
+            'The selected draft format must be stored on the service.');
+    end;
+
 }

src/Apps/W1/EDocumentConnectors/ForNAV/App/src/Setup/ForNAVPeppolSetup.Table.al

@@ -5,6 +5,7 @@
 namespace Microsoft.EServices.EDocumentConnector.ForNAV;
 
 using Microsoft.eServices.EDocument;
+using Microsoft.eServices.EDocument.Processing.Import;
 using Microsoft.Foundation.Address;
 using Microsoft.Foundation.Company;
 using Microsoft.Foundation.Reporting;
@@ -445,6 +446,9 @@ table 6414 "ForNAV Peppol Setup"
         EDocumentService."Service Integration V2" := EDocumentService.ForNAVServiceIntegration();
         EDocumentService."Document Format" := "E-Document Format"::"PEPPOL BIS 3.0";
         EDocumentService."Use Batch Processing" := false;
+        // ForNAV inbound import is not migrated to the v2 draft pipeline, so keep the service on Version 1.0
+        // instead of inheriting the new default of the "Import Process" field.
+        EDocumentService."Import Process" := "E-Document Import Process"::"Version 1.0";
         EDocumentService.Insert();
 
         EDocServiceSupportedType.SetRange(EDocServiceSupportedType."E-Document Service Code", EDocumentService.Code);